Payment methods options match Stripe settings when creating a payment source #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeholder
deleted the
bugfix/251-allow-the-bypass-of-payment_method_types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code was, currently, restricting the payment method types when creating a payment source. Although is possible to alter these using the
Gateway::EVENT_BUILD_SETUP_INTENT_REQUESTevent this was not intended behaviour.Removing this restrictions means that the options shown to a user when creating a payment source will match those methods enabled in Stripe's dashboard. This also means it now works in the same way as when a customer is making payment on an order.
Related issues
#251