Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape the pipe character for GitHub markdown table rendering #60

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jamesmacwhite
Copy link
Contributor

Description

The values of string|null when used in a markdown table causes a rendering issue on GitHub as the pipe character is also used to denote table columns, the backslash character has been used to escape the value, so it renders correctly.

image

Copy link
Collaborator

@timkelty timkelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timkelty timkelty merged commit e602f7b into craftcms:1.x Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants