Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spacing issues in UI #252

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Improve spacing issues in UI #252

merged 5 commits into from
Jan 23, 2025

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented Jun 14, 2024

This PR addresses spacing issues that regularly results in rogue trailing lines. It is based on the work of @devolute:
https://mastodon.social/@devolute/112615852011105973

  1. Sets the CKEditor branding to outside.
  2. Equalises vertical padding.
  3. Forces 0 padding after the last child in a list.

Before:

1be25a9b6ca46937

After:

949df88befc41946

@bencroker bencroker requested a review from brandonkelly as a code owner June 14, 2024 19:15
@brandonkelly brandonkelly changed the base branch from 3.x to 3.11 January 23, 2025 17:30
@brandonkelly brandonkelly merged commit c37f060 into craftcms:3.11 Jan 23, 2025
@brandonkelly
Copy link
Member

Thanks!

@brandonkelly
Copy link
Member

CKEditor 3.11.0 and 4.5.0 are out with that change!

@bencroker bencroker deleted the patch-1 branch January 23, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants