schema fix with testsRunDescription in the wrong place; fix for strin… #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g-escape-utils
This should fix the following 2 issues:
npx tsx src/bin/cql-tests.ts run-tests conf/development.json ./results
npm warn Unknown user config "pyls". This will stop working in the next major version of npm.
npm warn Unknown user config "/usr/bin/python3". This will stop working in the next major version of npm.
Warning: Could not validate configuration file conf/development.json: strict mode: unknown keyword: "testsRunDescription"
file:///Users/bryantaustin/Projects/cql-tests-runner/cvl/string-escape-utils.mjs:18
MULTI_CHAR_UNESCAPE.map(RegExp.escape).join('|') + '|\\u[0-9a-fA-F]{4}',
^
TypeError: undefined is not a function
at Array.map ()
at file:///Users/bryantaustin/Projects/cql-tests-runner/cvl/string-escape-utils.mjs:18:22
at ModuleJob.run (node:internal/modules/esm/module_job:268:25)
at async onImport.tracePromise.proto (node:internal/modules/esm/loader:543:26)
at async TestRunner.runTests (/Users/bryantaustin/Projects/cql-tests-runner/src/services/test-runner.ts:75:23)
at async RunCommand.execute (/Users/bryantaustin/Projects/cql-tests-runner/src/commands/run-tests-command.ts:22:21)
at async Command. (/Users/bryantaustin/Projects/cql-tests-runner/src/bin/cql-tests.ts:57:7)
Node.js v22.11.0
Raleigh did not get these errors. I had him test the changed cvl file and worked on his machine, without breaking anything else.