Skip to content

Conversation

@eisenwave
Copy link
Member

@eisenwave eisenwave commented Nov 9, 2025

Fixes #8454.

Fixes NB CA 041 (C++26 CD).
Fixes NB CA 092 (C++26 CD).
Fixes NB US 29-062 (C++26 CD).
Fixes NB US 35-066 (C++26 CD).
Fixes NB US 34-067 (C++26 CD).
Fixes NB US 60-110 (C++26 CD).
Fixes NB US 43-080 (C++26 CD).
Fixes NB US 15-032 (C++26 CD).
Fixes NB AT 4-099 (C++26 CD).
Fixes NB CA 045 (C++26 CD).
Fixes NB FR 155 (C++26 CD).

Also fixes cplusplus/CWG#546
Also fixes cplusplus/CWG#625
Also fixes https://github.com/cplusplus/nbballot/issues/616
Also fixes cplusplus/CWG#668
Also fixes cplusplus/CWG#681
Also fixes cplusplus/CWG#682
Also fixes cplusplus/CWG#685
Also fixes cplusplus/CWG#669
Also fixes https://github.com/cplusplus/nbballot/issues/669
Also fixes cplusplus/CWG#747
Also fixes cplusplus/CWG#751
Also fixes cplusplus/CWG#733
Also fixes cplusplus/CWG#756
Also fixes cplusplus/CWG#752
Also fixes cplusplus/CWG#750
Also fixes cplusplus/CWG#707
Also fixes cplusplus/CWG#759
Also fixes cplusplus/CWG#764
Also fixes cplusplus/CWG#761
Also fixes cplusplus/CWG#762
Also fixes cplusplus/CWG#767
Also fixes cplusplus/CWG#768
Also fixes cplusplus/CWG#769
Also fixes cplusplus/CWG#770
Also fixes cplusplus/CWG#755
Also fixes https://github.com/cplusplus/nbballot/issues/638
Also fixes https://github.com/cplusplus/nbballot/issues/642
Also fixes https://github.com/cplusplus/nbballot/issues/643
Also fixes https://github.com/cplusplus/nbballot/issues/688
Also fixes https://github.com/cplusplus/nbballot/issues/656
Also fixes https://github.com/cplusplus/nbballot/issues/607
Also fixes https://github.com/cplusplus/nbballot/issues/677
Also fixes https://github.com/cplusplus/nbballot/issues/620
Also fixes cplusplus/CWG#788
Also fixes cplusplus/CWG#780
Also fixes cplusplus/CWG#785
Also fixes cplusplus/CWG#786
Also fixes cplusplus/CWG#791
Also fixes https://github.com/cplusplus/nbballot/issues/734

@eisenwave eisenwave added this to the post-2025-11 milestone Nov 9, 2025
@eisenwave eisenwave changed the title CWG2555 Ineffective redeclaration prevention for using-declarators P3921R0 DR issues Nov 9, 2025
@eisenwave eisenwave force-pushed the motions-2025-11-cwg-1 branch from ba92856 to ef2b72c Compare November 9, 2025 11:41
@eisenwave eisenwave marked this pull request as ready for review November 9, 2025 15:17
@eisenwave
Copy link
Member Author

@jensmaurer how does the referencing of editorial submissions and NB comments work on these types of PRs?

  • Should I add a Fixes cplusplus/CWG/... for each?
  • Should I add a Fixes cplusplus/nbballot/... for each closed NB comment?
  • Should I add a Fixes NB ... (C++26 CD). to the respective commit messages?

@jensmaurer
Copy link
Member

jensmaurer commented Nov 12, 2025

Should I add a Fixes NB ... (C++26 CD). to the respective commit messages?

Yes, please. We want a permanent record of those.

The "(Also) fixes" for /CWG/ and /nbballot/ goes into the pull request (initial comment) only, but please do add these (you did, apparently) so that when Thomas merges this, all related issues are auto-closed. This is github-level org only, so doesn't go into the commit message.

@jensmaurer
Copy link
Member

Please fix

! Undefined control sequence.
2025-11-09T15:18:20.7047350Z l.7572 followed by \tocde
2025-11-09T15:18:20.7047500Z                          {dt}, and

Also, please check why this has merge conflicts.

@frederick-vs-ja

This comment was marked as resolved.

@eisenwave eisenwave added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 13, 2025
@tkoeppe tkoeppe changed the title P3921R0 DR issues CWG Poll 1: P3921R0 DR issues Nov 15, 2025
…h indirection/address operators

Fixes NB US 267-401 (C++26 CD).
Fixes NB CA 092 (C++26 CD).
Fixes NB US 43-080 (C++26 CD).
…dependent initializer

Fixes NB AT 4-099 (C++26 CD).
Fixes NB AT 4-099 (C++26 CD).
@eisenwave eisenwave force-pushed the motions-2025-11-cwg-1 branch from a87b471 to 5ac1488 Compare November 23, 2025 07:11
@eisenwave eisenwave removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 23, 2025
@eisenwave eisenwave requested a review from jensmaurer November 23, 2025 07:18
the new object is of the same type as \placeholder{e} (ignoring cv-qualification).
\end{itemize}
In this case, \placeholder{e} and the created object are
\defnadj{corresponding direct}{subobjects}{subobject}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use "defnadjx", I think.

$o_1$ and $o_2$ are corresponding direct subobjects\iref{intro.object} for which:
\begin{itemize}
\item the complete object of $o_1$ is not const or
\item $o_1$ is a mutable member subobject or subobject thereof.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "a" in front of "subobject"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment