[linalg.scaled.scaledaccessor] Use kebab-underscore_ style for exposition-only members #8424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not sure we want to proliferete that style. We should at least discuss this. |
tkoeppe
added
the
decision-required
…tion-only members The _`kebab-underscore_`_ style for exposition-only members seems to be consistently used among [linalg]. Although such style looks controversial, perhaps it's acceptable to achieve local consistency.
frederick-vs-ja
force-pushed
the
scaled_accessor-kebab-underscore_
branch
from
0dd8a22 to
03a8082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kebab-underscore_style for exposition-only members seems to be consistently used among [linalg]. Although such style looks controversial, perhaps it's acceptable to achieve local consistency.Towards #7214.