[lib] Replace bad uses of "instantiation" with "specialization" #8379
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
added
the
P1-Important
timsong-cpp
reviewed
Nov 16, 2025
Comment on lines
52
to
53
| pointers, the library class | ||
| \tcode{complex}, |
Contributor
There was a problem hiding this comment.
While we are here...should we also change this to say "specializations of complex" or something similar? complex is certainly not a class.
Member
There was a problem hiding this comment.
Akin? Analogous to?
"Comparable to" would probably be the most natural term, but that's overloaded in C++ too.
Contributor
Author
There was a problem hiding this comment.
"In other words, value types." also looks broken. I guess it's better to fix this later.
source/utilities.tex
Outdated
| heterogeneous, fixed-size collections of values. An instantiation of \tcode{tuple} with | ||
| two arguments is similar to an instantiation of \tcode{pair} with the same two arguments. | ||
| heterogeneous, fixed-size collections of values. A specialization of \tcode{tuple} with | ||
| two arguments is similar to a specialization of \tcode{pair} with the same two arguments. |
Contributor
There was a problem hiding this comment.
Drive by: can we find a word other than "similar" to avoid confusion with the Core Word of Power(TM)? Or just delete the sentence.
Contributor
Author
There was a problem hiding this comment.
I'm now attempting to use "behaves similarly" to avoid such confusion.
Affected sections: - [allocator.requirements.general] - [namespace.std] - [pointer.traits.types] - [allocator.traits.types] - [tuple.general] - [format.context] - [numeric.requirements] - [rand.util.canonical] - [thread.req.lockable.timed] - [thread.sharedtimedmutex.requirements.general] In [rand.util.canonical], it would be clearer to just say `generate_canonical` instead of "the instantiation" or "the specialization". Drive-by change: - In [tuple.general], change "is similar to" to "behaves similarly to" to avoid confusing with "similar types" in the core specification.
frederick-vs-ja
force-pushed
the
lib-no-bad-instantiations
branch
from
1703553 to
f7b3241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected sections:
In [rand.util.canonical], it would be clearer to just say
generate_canonicalinstead of "the instantiation" or "the specialization".Drive-by change:
Fixes #8222.