[strings] Consistently spell return types and types of data members #8107
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
string-return-types
branch
from
d915a0a to
f0e9337
Compare
frederick-vs-ja
force-pushed
the
string-return-types
branch
from
f0e9337 to
b481797
Compare
frederick-vs-ja
changed the title
jwakely
approved these changes
Nov 17, 2025
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
I like the string view changes.
I consider the (const_)reference typedefs to be mostly noise in string, since they're always just plain references, but I suppose the consistency doesn't do any harm, especially as string view already uses those typedefs.
jensmaurer
requested changes
Nov 20, 2025
Affected sections: - [basic.string.general] Align both overloads of `data` - [basic.string.general] Use `(const_)reference` for consistency with other sequence containers - [string.access] Use `(const_)reference` for consistency with other sequence containers - [string.view.template.general] Use `const charT*` for `data` and a data member, for the consistency with `basic_string`. -[string.view.access] Use `const charT*` for `data` for consistency with `basic_string`
frederick-vs-ja
force-pushed
the
string-return-types
branch
from
b481797 to
06257de
Compare
jensmaurer
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
basic_string::front/basic_string::back, the return types are modified to(const_)referencefor the consistency with other sequence containers.For
basic_string_view::data, the return types is modified toconst charT*for the consistency withbasic_string. The same change applies to spelling of the type of closely related exposition-only data memberdata_.