Skip to content

optimize(memory): DeleteAllVariableData add rollback log #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize(memory): DeleteAllVariableData add rollback log #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend/domain/memory/variables/internal/dal/variable_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"github.com/coze-dev/coze-studio/backend/domain/memory/variables/internal/dal/query"
"github.com/coze-dev/coze-studio/backend/infra/contract/idgen"
"github.com/coze-dev/coze-studio/backend/pkg/errorx"
"github.com/coze-dev/coze-studio/backend/pkg/logs"
"github.com/coze-dev/coze-studio/backend/types/errno"
)

Expand All @@ -50,7 +51,9 @@ func (v *VariablesDAO) DeleteAllVariableData(ctx context.Context, bizType projec

defer func() {
if err != nil {
tx.Rollback()
if e := tx.Rollback(); e != nil {
Copy link
Collaborator

@fanlv fanlv Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不打印是不是也没有什么问题，数据提交失败了。 Rollback 成功与否也没那么重要了？

logs.CtxErrorf(ctx, "rollback failed, err=%v", e)
}
}
}()

Expand Down