Skip to content

[fix][backend]add validateCreateTask #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2025
Merged

[fix][backend]add validateCreateTask #294

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
703c5ff
add validateCreateTaskReq
zero3233-bd Nov 6, 2025
85207ba
fix mutilpart proc
zero3233-bd Nov 7, 2025
75692f8
fix muti part proc
zero3233-bd Nov 7, 2025
f841a98
fix ut
zero3233-bd Nov 7, 2025
53cdb67
fix ut
zero3233-bd Nov 7, 2025
a708085
fix ut
zero3233-bd Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/modules/observability/application/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ func (t *TaskApplication) validateCreateTaskReq(ctx context.Context, req *task.C
return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("The start time must be earlier than the end time."))
}
}
if req.GetTask().GetRule().GetSampler().GetIsCycle() && req.GetTask().GetRule().GetSampler().GetCycleInterval() == 0 {
return errorx.NewByCode(obErrorx.CommercialCommonInvalidParamCodeCode, errorx.WithExtraMsg("invalid cycle_interval"))
}

return nil
}
Expand Down
Loading