Skip to content

Conversation

@tpfz
Copy link
Collaborator

@tpfz tpfz commented Nov 1, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

tpfz and others added 8 commits October 22, 2025 22:59
(LogID: 20251028165449010091110134177A0E5)

Co-Authored-By: Coda <[email protected]>
# Conflicts:
#	backend/api/router/coze/loop/apis/middleware.go
(LogID: 202510291452360100911101340058942)

Co-Authored-By: Coda <[email protected]>
(LogID: 20251030212451010091110134070EE5D)

Co-Authored-By: Coda <[email protected]>
* feat: [Coda] merge evaluation updates
(LogID: 20251025175940010091110134712B07F)

Co-Authored-By: Coda <[email protected]>

* feat: add InvokeEvaluator SPI thrift and run code gen

* feat: implement CustomRPCEvaluatorVersion DO entity

* feat: minor update spi field name

* 优化路由

* 优化名称

* 优化tag

* feat: minor updates after merging

* feat: add CustomRPCEvaluator DTO to EvaluatorContent DTO

* 优化接口

* feat: add more custom evaluator error code

* 增加日志

* 优化接口

* 优化list builtin接口

* fix repo

* fix update meta

* fix create Template

* feat: add CustomRPC to ConvertEvaluatorDTO2DO

* fix list Template

* feat: add CustomRPC support to evaluator CRUDs

* 增加tag多语言

* feat: minor improvements ValidateInput errorx

---------

Co-authored-by: tpfz <[email protected]>
Co-authored-by: Coda <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tpfz
❌ HearyShen


tpfz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tpfz
❌ HearyShen


tpfz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issues identified: several newly added HTTP handlers return 200 OK with empty payloads rather than invoking service logic; raw validation errors are exposed; GORM Debug() enabled in DAO; silent error handling on write path; and non-atomic multi-Update usage. Please address these before merge.

(LogID: 202511011729310100911101348364636)

Co-Authored-By: Coda <[email protected]>
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 82.34963% with 314 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...odules/evaluation/domain/service/evaluator_impl.go 70.52% 33 Missing and 18 partials ⚠️
.../evaluation/infra/repo/evaluator/evaluator_impl.go 83.13% 31 Missing and 11 partials ⚠️
...nd/modules/evaluation/application/evaluator_app.go 85.76% 27 Missing and 12 partials ⚠️
...aluation/domain/service/evaluator_template_impl.go 79.14% 23 Missing and 16 partials ⚠️
...on/infra/repo/evaluator/evaluator_template_impl.go 81.31% 21 Missing and 16 partials ⚠️
...d/modules/evaluation/application/experiment_app.go 65.88% 18 Missing and 11 partials ⚠️
...ation/application/convertor/evaluator/evaluator.go 85.62% 18 Missing and 4 partials ⚠️
...lication/convertor/evaluator/evaluator_template.go 85.33% 15 Missing and 7 partials ⚠️
...nd/api/handler/coze/loop/apis/evaluator_service.go 70.58% 10 Missing and 5 partials ⚠️
...kend/modules/evaluation/domain/entity/evaluator.go 75.00% 11 Missing ⚠️
... and 1 more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   68.03%   68.60%   +0.56%     
==========================================
  Files         568      575       +7     
  Lines       50482    52258    +1776     
==========================================
+ Hits        34345    35849    +1504     
- Misses      13470    13645     +175     
- Partials     2667     2764      +97     
Flag Coverage Δ
unittests 68.60% <82.34%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../evaluation/application/convertor/common/common.go 98.68% <100.00%> (+0.09%) ⬆️
backend/modules/evaluation/domain/entity/common.go 88.88% <ø> (ø)
.../modules/evaluation/domain/entity/evaluator_tag.go 100.00% <100.00%> (ø)
...les/evaluation/domain/entity/evaluator_template.go 100.00% <100.00%> (ø)
...tion/domain/entity/evaluator_version_custom_rpc.go 100.00% <100.00%> (ø)
backend/modules/evaluation/domain/entity/param.go 54.54% <ø> (ø)
...ation/domain/service/evaluator_source_code_impl.go 85.05% <100.00%> (ø)
...ion/domain/service/evaluator_source_prompt_impl.go 76.82% <100.00%> (+4.45%) ⬆️
backend/modules/evaluation/pkg/conf/evaluator.go 60.00% <ø> (-14.51%) ⬇️
...lity/domain/task/service/taskexe/tracehub/utils.go 90.66% <ø> (ø)
... and 11 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd543a8...c54575f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpfz tpfz force-pushed the feat/wzq/evaluator_ecosystem branch from 1c2d314 to 13a6ff0 Compare November 1, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants