Skip to content

Conversation

@dsf86
Copy link
Collaborator

@dsf86 dsf86 commented Oct 26, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

HymanShi and others added 30 commits September 22, 2025 19:46
Change-Id: I0efae3f7af582460e46ba629c0f470a10c326025
…ationSet, GetEvaluationSet, ListEvaluationSets

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
… convertor

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…ic to separate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…rate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…unified method parameter

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…error tracking

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
…DTO/xxxDTO2DO convention

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <[email protected]>
Change-Id: Ibfa77af15a79fc83b6fb5adc44dd132682fe1c05
…rchitecture

(LogID: 20250928231227010091094121028E1E4)

Co-Authored-By: Coda <[email protected]>
Change-Id: I54219f18349d50551302a3129d08ea25f1e15fa1
Change-Id: I4fc1842aea80465df2bfe1d9c7044905b7380cf1
Change-Id: Ic99ec4e867794d8f6d98c1d4bcad118158bb6969
Change-Id: I7d83bcded9ee778cd4baf63b2682053b88f42b44
Change-Id: Icbeb24eeebd9d6d5d67e1038b0f4acfce9d5759a
Change-Id: I7a78d11c6b3bdd59bb9a08d5cd9daf893c8afa15
Change-Id: I264264a0e8bbf776341fc2149377b7ba934d1c61
Change-Id: Iac21bc6194af354d9c4ad3a0e1a528cccd0f0c4f
Change-Id: I7972ba4c3b4b812652b86187366c2fdd03c7763e
Change-Id: I673a5dc343764edf228ec5d8a8219f0659d8278d
Change-Id: Ie1e50446c90172aea7292f134b117a37a84f0bce
Change-Id: Ia048d5d8836418597fa6ec48c602fbf48e197643
Change-Id: Ic21981040de379923d8a216a0f8fcf9b543072e6
dsf86 and others added 15 commits October 21, 2025 15:55
Change-Id: If9bd55665018d9115f49a1ab3e51fc2de8ea24f5
Change-Id: I6aa1cd19a32a9b918334506ed7ffa4f12f9f7286
Change-Id: I72213cc2529607b35f0e64edff4d337524fc1eb8
Change-Id: Ic922c699d863aa7848c90b1a9d90c55700ba1957
Change-Id: I81c1129f9dc778f5d6d6061f7361c7d2f677fd45
(LogID: 202510222206430100910941210024144)

Co-Authored-By: Coda <[email protected]>
Change-Id: I32413f6de6e34ee1da5514fd717c56c68143488e
Change-Id: I0ea45eaca2e39b95fc53e4108397ac5e5ecacf48
Change-Id: I772531a7191022bb836162749ec2ceb125eb70c6
Change-Id: Id12d537e2ceedb8c3048332bb5106dbc8a55abd6
Change-Id: Ia51bdaba158ccd456c5b8875600969b39add7d1a
(LogID: 20251026112148192168001003073C0F4)

Co-Authored-By: Coda <[email protected]>
Change-Id: I162c280ddaca914e7c5e74c2dfdd881da3921cc6
Change-Id: Id1c3b2d366c4c0de0f2916b531f4d8c6ac2b2734
Change-Id: I746f82aabd482b48f308062a7537e1bb03573e3c
@dsf86 dsf86 changed the title Feat open api eval feat open api eval Oct 26, 2025
Change-Id: Id42a353bdb928977cffac37cbe4ba2c44d89866a
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 89.98779% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...modules/evaluation/application/eval_openapi_app.go 90.78% 17 Missing and 17 partials ⚠️
...api/handler/coze/loop/apis/eval_open_apiservice.go 0.00% 21 Missing ⚠️
...d/modules/evaluation/infra/metrics/openapi/emit.go 46.66% 14 Missing and 2 partials ⚠️
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% 5 Missing ⚠️
...on/application/convertor/evaluation_set/openapi.go 98.94% 2 Missing and 2 partials ⚠️
backend/pkg/kitexutil/kitexutil.go 50.00% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   65.68%   67.40%   +1.72%     
==========================================
  Files         507      510       +3     
  Lines       57718    48673    -9045     
==========================================
- Hits        37912    32809    -5103     
+ Misses      17199    13235    -3964     
- Partials     2607     2629      +22     
Flag Coverage Δ
unittests 67.40% <89.98%> (+1.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on/convertor/evaluation_set/evaluation_set_item.go 46.76% <100.00%> (+2.19%) ⬆️
...es/evaluation/domain/entity/evaluation_set_item.go 72.72% <ø> (ø)
backend/modules/evaluation/domain/entity/param.go 54.54% <ø> (+5.70%) ⬆️
...luation/domain/service/evaluation_set_item_impl.go 100.00% <100.00%> (ø)
backend/pkg/kitexutil/kitexutil.go 50.00% <50.00%> (ø)
...on/application/convertor/evaluation_set/openapi.go 98.94% <98.94%> (ø)
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% <0.00%> (ø)
...d/modules/evaluation/infra/metrics/openapi/emit.go 46.66% <46.66%> (ø)
...api/handler/coze/loop/apis/eval_open_apiservice.go 0.00% <0.00%> (ø)
...modules/evaluation/application/eval_openapi_app.go 91.23% <90.78%> (-8.77%) ⬇️

... and 447 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f34db...6db4276. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dsf86 and others added 2 commits October 26, 2025 14:43
(LogID: 202510261432441921680010035228DDE)

Co-Authored-By: Coda <[email protected]>
Change-Id: I97c8c9ed5f7624580d2cdccba8398f3b97c85c57
@dsf86 dsf86 changed the title feat open api eval [feat] open api eval Oct 26, 2025
dsf86 added 4 commits October 26, 2025 14:51
Change-Id: I16a1394984c471fd00d93232f4add4a34d2c9932
Change-Id: I8222e498f8ebf23c00442d38d43f92c985352d11
Change-Id: I4bac1fad25dcc24397a6d91b7ee964215603bfa7
Change-Id: I2b2ef8380bcf7997d3c8119716eee4ac77c0ab33
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This PR introduces OpenAPI evaluation endpoints and supporting domain changes. I found two critical must-fix issues that will break the flow:

  1. Handler ReportEvalTargetInvokeResult does not invoke the service and returns an empty response, dropping incoming results.
  2. DatasetRPCAdapter.BatchUpdateDatasetItems is unimplemented and panics, causing BatchUpdateEvaluationSetItemsOApi to crash.

Additionally, there are should-fix improvements: guard against nil in ReportEvalTargetInvokeResult_ when computing latency, and avoid logging full payloads; also fix a misleading error message and a minor IDL comment typo. See inline comments for exact locations and suggested fixes.

dsf86 added 4 commits October 27, 2025 11:51
Change-Id: I1e2e724d6aa423fd0f8d416f51400a8961f3c0cf
Change-Id: I2385b811cfcee408f7602879eb77c8c6aa55ca0d
Change-Id: Ia08107bc3efef69d74b69843ea9221b7310637af
Change-Id: Id392b702f7da1baae8980abe24f645a5584f1cb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants