Ban solvers based on the settlements success rate #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/autopilot/src/domain/competition/participation_guard/db.rs
|
Reminder: Please consider backward compatibility when modifying the API specification.
Resolved |
squadgazzz
changed the title
fleupold
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Has this change been discussed with @harisang ? It's quite a steep intrusion into the arbitration cycle (any bonded solver is allowed to participate) and may require a CiP if we decide to selectively exclude solvers from the competition.
| pub struct LowSettlingValidatorConfig { | ||
| /// Enables search of non-settling solvers. | ||
| #[clap( | ||
| id = "low_settling_solvers_blacklisting_enabled", |
There was a problem hiding this comment.
By default, clap uses the variable name as an ID. For this particular case, since all the params are flattened, there will be 2 identical IDs for the enabled fields, so clap fails to parse the args without this annotation.
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
mstrug
reviewed
Feb 7, 2025
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # crates/autopilot/src/domain/competition/participation_guard/db.rs # crates/autopilot/src/domain/mod.rs # crates/autopilot/src/infra/solvers/dto/notify.rs # crates/driver/src/infra/api/routes/notify/dto/notify_request.rs # crates/driver/src/infra/solver/dto/notification.rs
# Conflicts: # crates/autopilot/src/infra/solvers/dto/notify.rs # crates/autopilot/src/infra/solvers/mod.rs # crates/driver/src/infra/api/routes/notify/dto/notify_request.rs
# Conflicts: # crates/autopilot/src/database/competition.rs # crates/autopilot/src/domain/competition/participation_guard/db.rs # crates/autopilot/src/domain/competition/participation_guard/mod.rs
mstrug
approved these changes
Feb 14, 2025
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # crates/autopilot/src/arguments.rs # crates/autopilot/src/domain/competition/participation_guard/db.rs # crates/autopilot/src/domain/competition/participation_guard/mod.rs # crates/autopilot/src/infra/mod.rs # crates/autopilot/src/infra/solvers/mod.rs
# Conflicts: # crates/autopilot/src/domain/competition/participation_guard/db.rs
crates/autopilot/src/domain/competition/participation_guard/db.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # crates/autopilot/src/domain/competition/participation_guard/db.rs
m-lord-renkse
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another follow-up to #3257, which implements a suggested statistic-based approach #3257 (comment).
Changes
Introduces an additional DB-based validator, which searches for solvers with less than 10%(configurable) of successful settlements among 100 last auctions(configurable).
How to test
A new SQL query test.