Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Remove executed_surplus_fee #3226

Merged
merged 2 commits into from
Feb 6, 2025
Merged

[3] Remove executed_surplus_fee #3226

merged 2 commits into from
Feb 6, 2025

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Jan 8, 2025 •
edited
Loading

Description

Fixes #3180

Will be merged once frontend team confirms they applied a release where they stopped using executed_surplus_fee.

Frontend team confirmed 👍
SAFE team confirmed 👍 .

Changes

  • Remove field that is no longer used.

How to test

Existing tests.

@sunce86 sunce86 self-assigned this Jan 8, 2025
@sunce86 sunce86 requested a review from a team as a code owner January 8, 2025 15:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

  • You explicitly pointed out breaking changes.
  • You communicate the changes to affected teams.
  • You provide proper versioning and migration mechanisms.

Caused by:

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 20, 2025
@sunce86 sunce86 removed the stale label Jan 20, 2025
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 28, 2025
@sunce86 sunce86 removed the stale label Jan 28, 2025
@sunce86 sunce86 changed the title Remove executed_surplus_fee [3] Remove executed_surplus_fee Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

@github-actions github-actions bot added the stale label Feb 6, 2025
@sunce86 sunce86 removed the stale label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

  • You explicitly pointed out breaking changes.
  • You communicate the changes to affected teams (at least Frontend team and SAFE team).
  • You provide proper versioning and migration mechanisms.

Caused by:

@sunce86
Copy link
Contributor Author

sunce86 commented Feb 6, 2025

cc @alfetopito merging this PR

@sunce86 sunce86 enabled auto-merge (squash) February 6, 2025 08:12
@sunce86 sunce86 merged commit 5874a92 into main Feb 6, 2025
11 checks passed
@sunce86 sunce86 deleted the remove_executed_surplus_fee branch February 6, 2025 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@squadgazzz squadgazzz squadgazzz approved these changes

@mstrug mstrug mstrug approved these changes

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

Assignees

@sunce86 sunce86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Remove executed_surplus_fee
6 participants
@sunce86 @MartinquaXD @squadgazzz @mstrug @m-lord-renkse @fleupold