Skip to content

Conversation

@cowboydaniel
Copy link
Owner

Summary

  • package the clangd runtime asset into the APK and fail assembly when it is missing or non-executable
  • load clangd from the packaged asset at runtime with explicit errors instead of placeholder fallbacks
  • remove the demo fallback path and update Android build documentation to reflect the mandatory clangd bundle

Testing

  • Not run (not requested)

Codex Task

@cowboydaniel cowboydaniel merged commit f3b951f into main Nov 20, 2025
1 check failed
@cowboydaniel cowboydaniel deleted the codex/package-clangd-for-android-and-document-steps branch November 20, 2025 13:20
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +324 to +327
lifecycleScope.launch {
val hover = if (::languageServerClient.isInitialized) {
languageServerClient.requestHover(activeFileUri, line, character)
} else null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard hover requests when language server not ready

The new maybeShowHelp path launches a hover request unconditionally; when clangd fails to start (e.g., packaged asset missing/non-executable) or is still initializing, RuntimeLanguageServerTransport.send immediately returns without emitting a response, so requestHover suspends forever and the coroutine never reaches the fallback docs dialog. Users who move the cursor before the LSP is ready will see the help UI hang silently and leak coroutines. Consider skipping the LSP call until status is Ready or timing out to fall back to the local docs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants