Skip to content

Replaces use of jQuery object as container with native Array #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anddoutoi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaces use of jQuery object as container with native Array #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions jquery.ba-outside-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@

// A jQuery object containing all elements to which the "outside" event is
// bound.
var elems = $(),
var elems = [],

// The "originating" event, namespaced for easy unbinding.
event_namespaced = event_name + '.' + outside_event_name + '-special-event';
Expand Down Expand Up @@ -165,7 +165,7 @@

// Add this element to the list of elements to which this "outside"
// event is bound.
elems = elems.add( this );
elems.push( this );

// If this is the first element getting the event bound, bind a handler
// to document to catch all corresponding "originating" events.
Expand All @@ -177,10 +177,13 @@
// Called only when the last "outside" event callback is unbound per
// element.
teardown: function(){
var index;

// Remove this element from the list of elements to which this
// "outside" event is bound.
elems = elems.not( this );
if ( -1 !== ( index = $.inArray( this, elems ) ) ) {
elems.splice( index, 1 );
}

// If this is the last element removed, remove the "originating" event
// handler on document that powers this "outside" event.
Expand Down Expand Up @@ -213,7 +216,7 @@
function handle_event( event ) {

// Iterate over all elements to which this "outside" event is bound.
$(elems).each(function(){
$.each( elems, function(){
var elem = $(this);

// If this element isn't the element on which the event was triggered,
Expand Down