-
Couldn't load subscription status.
- Fork 39
chore(atomic): migrate atomic-result-number #6188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: KIT-4997
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
|
|
||
| hostConnected() { | ||
| this.currentProps = this.getProps(); | ||
| if (this.host.error === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding this because the ItemContextController is setting the error to null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied the recommendations from the prompt execution reports after running them, hence the changes in the prompts.
AtomicResultNumber Component Specification
📝 Requirements
The
atomic-result-numbercomponent renders the value of a numeric result field.Functional requirements and constraints:
fieldprop (required, non-empty string) upon DOM connection and before updating, if needed.atomic-search-interface.atomic-format-number,atomic-format-currency, oratomic-format-unit) that takes precedence over the default number formatter.null.atomic-errorcomponent when itsfieldprop is invalid.atomic-errorcomponent when its received value cannot be parsed to a number.atomic-errorcomponent when its formatter throws.atomic-errorcomponent when rendered outside of anatomic-result-list.♿ Accessibility
⚡ Performance & Security
✅ Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-4974