-
Notifications
You must be signed in to change notification settings - Fork 39
chore(atomic): migrate FacetPlaceholder #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fbeaudoincoveo
wants to merge
12
commits into
KIT-4997
Choose a base branch
from
KIT-4943
base: KIT-4997
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334
−363
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aba2e2d
Migrate FacetPlaceholder
fbeaudoincoveo 3b9ed83
Improve / optimize functional component migration prompt
fbeaudoincoveo 3f5abd9
Add tests for renderFacetPlaceholder
fbeaudoincoveo 1baddc1
Review and optimize functional component UT generation prompt
fbeaudoincoveo 08d5f4c
Add todo tracking + harmonize post-exec summary
fbeaudoincoveo b204227
Merge branch 'KIT-4997' into KIT-4943
fbeaudoincoveo a879ba0
Remove superfluous comments
fbeaudoincoveo 2e098a6
Clean up tests
fbeaudoincoveo 7bc70e3
Merge branch 'KIT-4997' into KIT-4943
fbeaudoincoveo 5a1b5e0
Rename original file
fbeaudoincoveo 8c571c0
Merge branch 'KIT-4997' into KIT-4943
fbeaudoincoveo a6f22fe
Update bad import path
fbeaudoincoveo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this PR include changes to these two prompts?