Skip to content

refactor: use t.TempDir() instead of os.MkdirTemp#2564

Open
yuhangcangqian wants to merge 1 commit intocosmos:mainfrom
yuhangcangqian:main
Open

refactor: use t.TempDir() instead of os.MkdirTemp#2564
yuhangcangqian wants to merge 1 commit intocosmos:mainfrom
yuhangcangqian:main

Conversation

@yuhangcangqian
Copy link
Copy Markdown

@yuhangcangqian yuhangcangqian commented Mar 8, 2025

Description

TempDir returns a temporary directory for the test to use.The directory is automatically removed when the test and
all its subtests complete. More info https://pkg.go.dev/testing#B.TempDir


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@yuhangcangqian yuhangcangqian requested a review from a team March 8, 2025 05:31
@github-actions github-actions Bot added the C:Testing Assigned automatically by the PR labeler label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:Testing Assigned automatically by the PR labeler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant