Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm unnecessary code for eureka #1372

Open
wants to merge 17 commits into
base: rano/eureka/1364
Choose a base branch
from

rm TimeoutOnClose

51f4c22
Select commit
Loading
Failed to load commit list.
Open

refactor: rm unnecessary code for eureka #1372

rm TimeoutOnClose
51f4c22
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2024 in 0s

58.75% (-8.10%) compared to cdd4625

View this Pull Request on Codecov

58.75% (-8.10%) compared to cdd4625

Details

Codecov Report

Attention: Patch coverage is 18.49164% with 3707 lines in your changes missing coverage. Please review.

Project coverage is 58.75%. Comparing base (cdd4625) to head (51f4c22).

Files with missing lines Patch % Lines
...-eureka-core/ics04-channel/types/src/events/mod.rs 0.00% 591 Missing ⚠️
ibc-eureka-core/ics24-host/types/src/path.rs 0.00% 523 Missing ⚠️
ibc-eureka-core/ics02-client/types/src/events.rs 52.83% 191 Missing ⚠️
...reka-core/ics04-channel/src/handler/recv_packet.rs 0.00% 149 Missing ⚠️
...c-eureka-core/ics23-commitment/types/src/merkle.rs 0.00% 146 Missing ⚠️
ibc-eureka-core/ics04-channel/types/src/packet.rs 0.00% 141 Missing ⚠️
...c-eureka-core/ics04-channel/src/handler/timeout.rs 0.00% 128 Missing ⚠️
...-core/ics04-channel/src/handler/acknowledgement.rs 0.00% 111 Missing ⚠️
...reka-core/ics04-channel/src/handler/send_packet.rs 0.00% 96 Missing ⚠️
...cs04-channel/types/src/events/packet_attributes.rs 0.00% 88 Missing ⚠️
... and 48 more
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           feat/ibc-eureka    #1365      +/-   ##
===================================================
- Coverage            66.84%   58.75%   -8.10%     
===================================================
  Files                  225      285      +60     
  Lines                22631    27179    +4548     
===================================================
+ Hits                 15127    15968     +841     
- Misses                7504    11211    +3707

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov