chore (02-client): update err return genesis state validate#7800
Closed
solkorap7 wants to merge 1 commit intocosmos:mainfrom
Closed
chore (02-client): update err return genesis state validate#7800solkorap7 wants to merge 1 commit intocosmos:mainfrom
solkorap7 wants to merge 1 commit intocosmos:mainfrom
Conversation
Contributor
|
Hi @solkorap7, while this could be nice to have, I am not very concerned about this for the genesis validation. But more importantly, most of the error types are incorrect. I believe this is not really worth spending too much time on, so I will close the PR for now. For the future, I suggest you either find an existing issue, or open an issue for discussion before opening a PR. To make the maintenance burden lower we will likely require an issue for every PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error return type is obsolete (4 years ago)
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.