refactor: use branch service in recv packet (wip)

[damiannolan]

Description

closes: #XXXX

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/).
• Added relevant godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

[damiannolan]

It seems that we can't maintain backwards compatibility here with error prefixing events from the cached context passed to the ibc app in RecvPacket.

A potential solution could be to do something like this, if we added the Events() api back to EventService / EventManager - as the underlying implementation is the same as it used to be on the sdk.Context.

If we do not shadow the context variable passed to the func in BranchService.Execute(), we may be able to do something like the following:

if err := k.BranchService.Execute(ctx, func(cacheCtx context.Context) error {
	// Perform application logic callback
	ack = cbs.OnRecvPacket(cacheCtx, channelVersion, msg.Packet, relayer)
	if ack == nil || ack.Success() {
		// write application state changes for asynchronous and successful acknowledgements
		return nil
	} else {
		events := k.EventService.EventManager(cacheCtx).Events()
		for _, evt := range events {
			k.EventService.EventManager(ctx).EmitKV(evt.EventType, evt.Attributes...)
		}
	}

	// we must return an error here so that false positive events are not emitted
	return channeltypes.ErrFailedAcknowledgement
}); err != nil {
...
}