Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(depinject): support for 29-fee #6154

Merged
merged 22 commits into from
Apr 19, 2024
Merged

feat(depinject): support for 29-fee #6154

merged 22 commits into from
Apr 19, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

Adding support for 29-fee package.

ref: #3560

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 15, 2024 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@crodriguezvega crodriguezvega mentioned this pull request Apr 15, 2024
Open
3 tasks
Carlos Rodriguez added 2 commits April 15, 2024 10:10
@damiannolan damiannolan self-assigned this Apr 15, 2024
Base automatically changed from carlos/add-buf-gen-pulsar to feat/depinject April 18, 2024 09:57
Merge branch 'feat/depinject' into carlos/3650-depinject-support-fee
5c85a91 
# Conflicts:
#	api/capability/v1/capability.pulsar.go
#	api/capability/v1/genesis.pulsar.go
#	api/go.mod
#	api/go.sum
#	api/ibc/applications/fee/v1/fee.pulsar.go
#	api/ibc/applications/fee/v1/query.pulsar.go
#	api/ibc/applications/fee/v1/tx.pulsar.go
#	api/ibc/applications/interchain_accounts/controller/v1/tx.pulsar.go
#	api/ibc/applications/interchain_accounts/host/v1/host.pulsar.go
#	api/ibc/applications/interchain_accounts/host/v1/tx.pulsar.go
#	api/ibc/applications/interchain_accounts/v1/account.pulsar.go
#	api/ibc/applications/interchain_accounts/v1/packet.pulsar.go
#	api/ibc/applications/transfer/v1/authz.pulsar.go
#	api/ibc/applications/transfer/v1/genesis.pulsar.go
#	api/ibc/applications/transfer/v1/query.pulsar.go
#	api/ibc/applications/transfer/v1/tx.pulsar.go
#	api/ibc/core/channel/v1/query.pulsar.go
#	api/ibc/core/channel/v1/tx.pulsar.go
#	api/ibc/core/client/v1/client.pulsar.go
#	api/ibc/core/client/v1/query.pulsar.go
#	api/ibc/core/client/v1/tx.pulsar.go
#	api/ibc/core/commitment/v1/commitment.pulsar.go
#	api/ibc/core/connection/v1/query.pulsar.go
#	api/ibc/core/connection/v1/tx.pulsar.go
#	api/ibc/lightclients/solomachine/v2/solomachine.pulsar.go
#	api/ibc/lightclients/solomachine/v3/solomachine.pulsar.go
#	api/ibc/lightclients/tendermint/v1/tendermint.pulsar.go
#	api/ibc/lightclients/wasm/v1/query.pulsar.go
#	api/ibc/lightclients/wasm/v1/tx.pulsar.go
#	e2e/go.mod
#	proto/buf.gen.pulsar.yaml
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

damiannolan
damiannolan approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged as well.

My main concerns around app wiring and how the dependency injection knows how to pass certain arguments such as ICS4Wrapper to each module when each can have a different keeper fulfilling that role.
As well as the other concerns around setting up the client/port routers correctly, but this should be doable I think!

modules/apps/29-fee/depinject.go
Cdc codec.Codec
Key *storetypes.KVStoreKey

Ics4Wrapper porttypes.ICS4Wrapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same nit

Suggested change
Ics4Wrapper porttypes.ICS4Wrapper
ICS4Wrapper porttypes.ICS4Wrapper

proto/ibc/applications/fee/module/v1/module.proto
import "cosmos/app/v1alpha1/module.proto";

// Module is the config object of the 29-fee module.
message Module {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have authority for 29-fee, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't

@crodriguezvega crodriguezvega merged commit bae5771 into feat/depinject Apr 19, 2024
73 of 74 checks passed
@crodriguezvega crodriguezvega deleted the carlos/3650-depinject-support-fee branch April 19, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk

@chatton chatton Awaiting requested review from chatton

@charleenfei charleenfei Awaiting requested review from charleenfei

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

Assignees

@damiannolan damiannolan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crodriguezvega @damiannolan