Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(depinject): add buf pulsar generation #4039

Closed
wants to merge 130 commits into from

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jul 7, 2023

Description

My proto fu is pretty weak, so I honestly got this by looking at the SDK and following the infallible scientific method of trial and error... I followed the same structure as SDK with a api folder at the root with all the pulsar files.

According to @julienrbrt we need to compile the module.proto files used for dependency injection with pulsar because proto-gen-gogo will not generate code that implements the necessary interfaces.

ref: #3560

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@julienrbrt
Copy link
Member

julienrbrt commented Jul 7, 2023

According to @julienrbrt we need to compile the module.proto files used for dependency injection with pulsar because proto-gen-gogo will not generate code that implements the necessary interfaces.

I just want to clarify that you do not really need to use pulsar (protoc-gen-go-pulsar), you could use protoc-gen-go (https://protobuf.dev/reference/go/go-generated) as well. However pulsar is fine :)

@crodriguezvega
Copy link
Contributor Author

I just want to clarify that you do not really need to use pulsar (protoc-gen-go-pulsar), you could use protoc-gen-go (https://protobuf.dev/reference/go/go-generated) as well. However pulsar is fine :)

True. :) But since SDK is using pulsar, then I guess it's good to follow the example. :)

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

faddat and others added 22 commits August 21, 2023 14:26
* refactor(ica): refactored packet data's  unmarshal logic

* fix(ica_test): made tests pass

* imp(ica): changed to UnmarshalJSON api

* docs(ica): added godocs to iapd's 'UnmarshalJSON' method
* imp(callbacks_test): checking that processCallback consumes gas from callback execution

* imp(callbacks_test): simplified success test case a bit
* build(deps): Bump cosmossdk.io/math from 1.0.1 to 1.1.1

Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.0.1 to 1.1.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@math/v1.0.1...math/v1.1.1)

---
updated-dependencies:
- dependency-name: cosmossdk.io/math
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump in e2e, callbacks, tidy.

* bump cosmossdk.io/math to v1.1.2 across all go modules

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
* add unparam linter

* remove unused-param from revive, add comments.

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
* bump the proto image builder and golangci-lint

* address implicit memory aliasing

---------

Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
…4358)

* docs(callbacks): added godocs for send packet validation

* docs(callbacks): improved godocs

* docs(callbacks): used colin and damian suggested doc string

* docs(callbacks): fixed typo

* docs(callbacks): improved a minor typo
…ity (#4399)

* update all modules to go 1.2.1

* update golang in the Dockerfile

* update cosmos-sdk in capability module

---------

Co-authored-by: colin axnér <[email protected]>
…gic (#4375)

* imp(callbacks/mock/contract_keeeper): improved contract keeper logic

* imp(callbacks_test): fixed transfer_test.go

* imp(callbacks_test): fixed ica_test.go

* imp(callbacks_test): fixed fee_transfer_test.go

* style(callbacks_test): removed unneeded gas_limit

* style: ran golangci-lint

* imp(callbacks_test): implemented simplified logic

* imp(callbacks_test): removed unneeded variable

* imp(callbacks): implemented some review feedback

* docs(callbacks/simapp): updated godocs of mock contract keeper functions
* update interchaintest to latest upstream code

* update all modules to go 1.2.1

* update golang in the Dockerfile

* use sdk math in the right places

* math to int64 where needed

* additional patches

* attempt (again)

* test the fix

* correct earlier errors

* update incorrect updates

* update incorrect iavl

* update incorrect iavl version

* re-introdue "the bug"

* use int instead of math.Int in GetAndFundTestUsers

* fix TestInterchainAccountsGroupsTest

* fix TestAuthz_InvalidTransferAuthorizations

* fix the rest of the tests ?

* convert to int64

* convert actualBalance to int64

* Revert "convert actualBalance to int64"

This reverts commit e4df8f3.

* convert balance to int64 in ica localhost test

* convert balance in interchain accounts base_test.go line 222

* convert actualBalance in line 109 of transfer's base_test.go to int64

* can we use zeroint like that?

* preassign zero

* use sdkmath.NewInt

* properly call sdkmath.ZeroInt()

---------

Co-authored-by: catShaark <[email protected]>
Co-authored-by: khanh-notional <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
…rshaler interfaces (#4435)

* docs: add docs for PacketData and PacketDataProvider

* docs: add docs for PacketDataUnmarshaler

* Apply suggestions from code review

Co-authored-by: srdtrk <[email protected]>

---------

Co-authored-by: srdtrk <[email protected]>
…ditionally on version (#4428)

* wip: fixing failing params test

* fine tuned host enabled params test

* Use slices.DeleteFunc, fix LocalhostClientFeatureReleases docstring.

---------

Co-authored-by: DimitrisJim <[email protected]>
* feat(callbacks_test): added 'GetExpectedEvent' function

* imp(callbacks_test): implemented event testing for SendPacket

* style: ran golangci-lint

* imp(callbacks_test): implemented event checking in every callback function

* style: simplified the event tests

* docs(callbacks_test): added godocs to a test helper function

* imp(callbacks_test): implemented review item
* linter autofixes for e2e

* lint e2e fully

---------

Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
* docs: added callbacks middleware overview

* docs: added interfaces.md to callbacks

* docs: added usage to callback docs

* docs: added events to callbacks docs

* docs: integration docs for callbacks added

* docs: added user defined gas limit to callbacks/usage

* docs: renamed usage.md -> end-users.md

* docs: added callbacks docs to config.js

* docs: improved interfaces slightly

* docs: added order frontmatter to markdown files

* 2-space tabs for better readability

* docs: improved callbacks/interfaces.md

* docs: improved callbacks/overview.md

* docs: improved callbacks/integration.md

* docs: improved callbacks/end-users.md

* docs: improved callbacks/interfaces.md

* docs: added callbacks diagrams

* docs: added the new diagrams to overview.md

* docs: added improvements to callback docs'

* docs: gas.md added to callbacks docs

* docs: minor grammar improvement

* docs: fixed another grammar error in callbacks

* docs: implemented review items

* code formatting and fix typo

* docs: improved the callback diagram

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
* cast to ICS4Wrapper

* fix(callbacks_test): reverted some of the casts

---------

Co-authored-by: srdtrk <[email protected]>
faddat and others added 27 commits September 19, 2023 09:42
* remove storekey from interchain accounts

* bump cosmos-sdk

* fix markdown links

* restore go modules to main and update simulation registry

---------

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Charly <[email protected]>
* docs: fix broken sdk links

* docs: fix broken sdk links
* update adr8 to latest implementation decisions

* fix link

* fixed relationship between CallbackPacketData and packet data interfaces

* update changelog

* Apply suggestions from code review

Co-authored-by: srdtrk <[email protected]>

* fix(docs): fix broken link

* address rest of comments

* Update docs/architecture/adr-008-app-caller-cbs.md

Co-authored-by: srdtrk <[email protected]>

* Apply suggestions from code review

Co-authored-by: srdtrk <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
Co-authored-by: srdtrk <[email protected]>

---------

Co-authored-by: srdtrk <[email protected]>
Co-authored-by: srdtrk <[email protected]>
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(packet): get next send sequence for transfer packets

* chore(channels): fixed tests for unordered sequence

* Update modules/core/04-channel/keeper/grpc_query_test.go

Co-authored-by: Carlos Rodriguez <[email protected]>

* chore: removed useless error handling

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
* chore: add HasValidateBasic compiler assertions to msgs

* linting

---------

Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
* docs: migrate to docusaurus (#3511)

The following stack was used:
- Docusaurus 2
- tailwindcss
- postcss

Min required node version is: 16.14
---------

Co-authored-by: colin axnér <[email protected]>

* merge: fixing conficts

* merge: bringing back client docs

* merge: removing versions again

* merge: fix conflicts

* fix: merge conflicts

* fix: merge conflicts

* fix: merge conflicts

* docs: implement versioned documentation (#3577)

* docs: workflow and linter improvements (#3805)

* docs: added version 7.0.0 docs, need to check for bugs

* docs: renamed the version to v7.0.0

* docs: added v6.1.0

* docs: added v5.3.0

* docs: added v4.4.0

* docs: updated the base url redirect, and version banners

* docs: replaced 'Pre-requisites Readings' -> 'Pre-requisite readings'

* docs: added missing ADRs to README.md

* docs: added versioning info to README.md

* docs: replaced '../../../../docs/architecture/adr-001-coin-source-tracing.md' -> '../../../architecture/adr-001-coin-source-tracing.md'

* docs: updated the url of the 7.0.0 (latest)

* docs: fixed all broken links

* docs: updated 'make build-docs' command to use docusaurus

* docs: Added a Links section to README.md

* docs: updated code blocks in 02-integration.md to use docusaurus features as an example

* docs: removed all TODOs from README.md

* docs: updated the typical versioned docs tree in README.md

* docs: made file naming section more precise

* docs: updated README.md

* docs: updated release-tracker.md

* docs: removed search section from README.md

* docs: updated release-management.md

* docs: updated Makefile

* docs: fixed more broken links

* docs: updated workflows to only run when changes to main occur (not releases)

* fix(ci): attempt to convert absolute urls to absolute filepaths in the ci

* fix(ci): added '@site/' to ignorePatterns instead

* imp(docs): removed wrong comment

* fix(ci): fix markdown-link-check for docusaurus

* docs: changed architecture links to absolute links

* fix(ci): replace only affects architect and event links now

* docs: fix broken more links

* imp(ci): ignore http links in markdown-link-check replace statements

* imp(ci): markdown-link-check should only run on modified md files

* fix(ci): attempt to fix markdown-link-check

* fix(ci): only check modified files for markdown-link-check

* revert(ci): reverted link-check.yml to initial state

* imp(ci): set link check timeout to 16 mins

* imp(ci/link-check): link-check should ignore versioned_docs now

* fix(ci/link-check): attempt to ignore files ending with '/'

* docs: fixed broken link

* docs: fixed broken link in RELEASES.md

* fix(ci/link-check): config works now

* refactor(ci/link-check): combined two regexp patterns into one in link-check config

* fix(ci/link-check): config is good - attempt to fix the workflow

* fix(ci/link-check): config is good - attempt to fix the workflow

* fix(ci/link-check): added verbose mode

* revert(ci/link-check): reverted workflow to initial state (not config)

* nit: broke a link to test ci

* revert(docs): fixed broken link

* build(docs/deps): updated docusaurus to 2.4.1

* docs: replaced intro titles

* docs: remove extra ')'

* docs: wrapped some prerequisites in note

* docs: replaces '::: tip' with ':::tip'

* docs: replace '::: warning' with ':::warning'

* docs: fix styling error

* docs: readme updated

* docs: removed all references to 'order:' frontmatter

* docs: fixed list styling in transfer/state-transitions

* docs: removed unneeded quotation

* imp(docs): improved the markdownlint settings

* imp(docs): improved the markdownlint settings

* docs: ran markdownlint with the new config

* docs: do not lint autogenerated CHANGELOG.md

* docs: removed 'bash' from the codeblock in the PR template

* docs: added '.github' to .markdownlintignore

* imp(docs): added more comments to markdownlint config

* docs: fixed incorrect category linking

* docs: fixed indentation issue in fee middleware

* imp(docs): added two more rules to markdownlint

* docs: ran 'make docs-lint'

* docs: made transfer the first app

* docs: made transfer the first app in all versions

* imp(makefile/docs): added link-check to makefile

* docs: added back the spaces

* docs: fixed a lint violation

* docs: contents of DOCS_GUIDELINES.md have been merged with README.md

* docs: ran markdownlint-cli

* docs: fixed a lot of linting errors

* docs: fixed a more linting errors

* docs: fixed all linting errors

* docs: corrected PR template's code box

* imp(docs): add a new workflow for linting changed markdown files

* docs: fixed linter violation

* imp(docs): switch to using markdownlint-cli2

* revert(ci/markdown-lint): original state

* imp(ci/markdown-lint): fix an error

* imp(ci/markdown-lint): only runs on PRs which modify .md files

* imp(ci/markdown-lint): only runs on PRs which modify .md files not in .github

* docs: fixed broken link

* imp(ci/link-check): this workflow only runs if a .md file has been modified

* deps(docs): ran 'npm i --save @easyops-cn/docusaurus-search-local'

* feat(docs): added local search bar

* fix(docs): search bar highlight color is not buggy anymore

* imp(docs): added term highlighting to search

* fix: merge conflicts

* docs: ran linter

* refactor: removed markdownlint changes in this PR

* refactor: removed markdownlint changes in this PR

* refactor: removed linkcheck changes in this PR

* revert: changes in PR template

* revert: added swagger-docs thing back

* revert: "revert: added swagger-docs thing back"

This reverts commit f6cdcdb.

* revert: "revert: changes in PR template"

This reverts commit 5a23809.

* revert: "refactor: removed linkcheck changes in this PR"

This reverts commit b401b31.

* revert: "refactor: removed markdownlint changes in this PR"

This reverts commit eb31283.

* revert: "refactor: removed markdownlint changes in this PR"

This reverts commit d5b74e0.

* add extra path to ignore

* docs linting

* Update docs/docs/01-ibc/09-roadmap.md

Co-authored-by: Charly <[email protected]>

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Charly <[email protected]>

* feat: v7.3.x docs added

* imp: improved Makefile for serving docs

* imp: checked out some problematic files

* fix: merge conflicts

* imp(docs): added versioned docs for v6.2.x

* ci: switched to docusaurus check and deploy workflows (#4688)

* ci: switched to docusaurus check and deploy workflows

* ci: added workflow_dispatch back to deploy-docs

* imp(lint): ignores all changelogs now

* imp: ran linter

* imp(makefile): improved build-docs

* fix(docs): broken links

* imp: improved workflows around markdownlint

* imp: improved workflows around markdownlint

* imp(docs): added the new ibc assets

* deps(docs): updated deps

* style(docs): reorganized footer code

* docs: fix cosmos-sdk broken links

* imp(docs): removed link from the footer logo

* imp(docs): improved footer

* imp(docs): added a link to privacy policy

* deps(docs): added 'npm run dev' script

* imp(docs): apply review item

* imp: ran 'make docs-lint'

* imp: added 'make tag-docs-version'

---------

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Charly <[email protected]>
* chore: re-adding ClientUpdateProposal types and interface impl

* chore: re-adding legacy proposal handler and surrounds

* chore: remove dead code and route to RecoverClient, adding deprecation comments inline

* chore: remove unused event emission func

* chore: remove unused event type and error

* make format

* chore: adding deprecation notice to legacy_proposal.go, attempt to fix linter

* chore: attempt to silence deprecation linter

* chore: adding comment in golangci.yml
* imp: added CNAME file

* imp: added deployment branch to docusaurus config

* imp: added trailing slash conf

* imp: updated url

* imp: added new deploy workflow

* ci: fix build dir deploy docs

* fix: broken logo link
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…4736)

Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 12 to 13.
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)
- [Commits](DavidAnson/markdownlint-cli2-action@v12...v13)

---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Damian Nolan <[email protected]>
…4.4.3 (#4735)

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.1 to 4.4.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/jamesives/github-pages-deploy-action/releases">JamesIves/github-pages-deploy-action's releases</a>.</em></p>
<blockquote>
<h2>v4.4.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump <code>@​types/node</code> from 18.8.0 to 18.8.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1239">JamesIves/github-pages-deploy-action#1239</a></li>
<li>Bump webfactory/ssh-agent from 0.5.4 to 0.7.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1252">JamesIves/github-pages-deploy-action#1252</a></li>
<li>Bump <code>@​types/node</code> from 18.8.4 to 18.11.9 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1262">JamesIves/github-pages-deploy-action#1262</a></li>
<li>Bump eslint-plugin-jest from 27.0.4 to 27.1.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1268">JamesIves/github-pages-deploy-action#1268</a></li>
<li>Bump <code>@​types/node</code> from 18.11.9 to 18.11.10 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1276">JamesIves/github-pages-deploy-action#1276</a></li>
<li>Bump <code>@​types/node</code> from 18.11.10 to 18.11.13 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1283">JamesIves/github-pages-deploy-action#1283</a></li>
<li>Bump eslint-config-prettier from 8.5.0 to 8.6.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1293">JamesIves/github-pages-deploy-action#1293</a></li>
<li>Bump json5 from 2.1.1 to 2.2.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1294">JamesIves/github-pages-deploy-action#1294</a></li>
<li>Bump minimatch from 3.0.4 to 3.1.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1270">JamesIves/github-pages-deploy-action#1270</a></li>
<li>Bump decode-uri-component from 0.2.0 to 0.2.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1277">JamesIves/github-pages-deploy-action#1277</a></li>
<li>Bump typescript from 4.8.4 to 4.9.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1281">JamesIves/github-pages-deploy-action#1281</a></li>
<li>Bump eslint-plugin-jest from 27.1.5 to 27.2.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1296">JamesIves/github-pages-deploy-action#1296</a></li>
<li>Bump rimraf from 3.0.2 to 4.1.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1307">JamesIves/github-pages-deploy-action#1307</a></li>
<li>Bump typescript from 4.9.4 to 4.9.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1311">JamesIves/github-pages-deploy-action#1311</a></li>
<li>Bump codecov/codecov-action from 3.1.1 to 3.1.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1353">JamesIves/github-pages-deploy-action#1353</a></li>
<li>Bump <code>@​types/node</code> from 18.11.13 to 18.16.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1361">JamesIves/github-pages-deploy-action#1361</a></li>
<li>Bump codecov/codecov-action from 3.1.2 to 3.1.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1372">JamesIves/github-pages-deploy-action#1372</a></li>
<li>Bump <code>@​actions/io</code> from 1.1.2 to 1.1.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1339">JamesIves/github-pages-deploy-action#1339</a></li>
<li>Bump prettier from 2.7.1 to 2.8.8 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1357">JamesIves/github-pages-deploy-action#1357</a></li>
<li>Bump <code>@​types/node</code> from 18.16.3 to 20.2.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1380">JamesIves/github-pages-deploy-action#1380</a></li>
<li>Bump webfactory/ssh-agent from 0.7.0 to 0.8.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1348">JamesIves/github-pages-deploy-action#1348</a></li>
<li>Bump eslint-config-prettier from 8.6.0 to 8.8.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1342">JamesIves/github-pages-deploy-action#1342</a></li>
<li>Bump <code>@​types/node</code> from 20.2.3 to 20.2.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1381">JamesIves/github-pages-deploy-action#1381</a></li>
<li>Bump <code>@​types/node</code> from 20.2.4 to 20.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1383">JamesIves/github-pages-deploy-action#1383</a></li>
<li>Bump <code>@​types/node</code> from 20.2.5 to 20.3.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1385">JamesIves/github-pages-deploy-action#1385</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1386">JamesIves/github-pages-deploy-action#1386</a></li>
<li>Bump <code>@​types/node</code> from 20.3.1 to 20.3.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1387">JamesIves/github-pages-deploy-action#1387</a></li>
<li>Bump <code>@​types/node</code> from 20.3.2 to 20.3.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1389">JamesIves/github-pages-deploy-action#1389</a></li>
<li>Bump semver from 5.7.1 to 5.7.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1396">JamesIves/github-pages-deploy-action#1396</a></li>
<li>Bump tough-cookie from 4.0.0 to 4.1.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1394">JamesIves/github-pages-deploy-action#1394</a></li>
<li>Bump <code>@​types/node</code> from 20.3.3 to 20.4.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1395">JamesIves/github-pages-deploy-action#1395</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.4.3">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.4.3</a></p>
<h2>v4.4.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Dependency updates</li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.4.2">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.4.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/a1ea191d508feb8485aceba848389d49f80ca2dc"><code>a1ea191</code></a> Deploy Production Code for Commit a8bd9aef1855024c235ad911985c97e153ddc9c4 🚀</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/a8bd9aef1855024c235ad911985c97e153ddc9c4"><code>a8bd9ae</code></a> Merge branch 'dev' into releases/v4</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/7e13873dee76cdcb5d247f8c10ab5871c0b2418a"><code>7e13873</code></a> Bump <code>@​types/node</code> from 20.3.3 to 20.4.1 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1395">#1395</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/da986918281e44cc68ab44229f63d49f2f13b389"><code>da98691</code></a> Bump tough-cookie from 4.0.0 to 4.1.3 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1394">#1394</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/4a6bcf161550cade762c80e51159b5a8d20b7920"><code>4a6bcf1</code></a> Bump semver from 5.7.1 to 5.7.2 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1396">#1396</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/426d422c1c72978c4c926ef8dcf600b3c5ced561"><code>426d422</code></a> Bump <code>@​types/node</code> from 20.3.2 to 20.3.3 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1389">#1389</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/6c78091d858515ea8cd1db9b735f1312197d7773"><code>6c78091</code></a> Bump <code>@​types/node</code> from 20.3.1 to 20.3.2 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1387">#1387</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/dbbf76c054a31d7ac44d8f0bb381fba0a47d1c80"><code>dbbf76c</code></a> Deploying to dev from @ JamesIves/github-pages-deploy-action@ce9d786e639c4709...</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/ce9d786e639c47093af973a5d65242993b6913bb"><code>ce9d786</code></a> Bump eslint-plugin-jest from 27.2.1 to 27.2.2 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1386">#1386</a>)</li>
<li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/e33c1e26e1b70d7da5746d4165ba79b49029dfef"><code>e33c1e2</code></a> Bump <code>@​types/node</code> from 20.2.5 to 20.3.1 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1385">#1385</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/jamesives/github-pages-deploy-action/compare/v4.4.1...v4.4.3">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=JamesIves/github-pages-deploy-action&package-manager=github_actions&previous-version=4.4.1&new-version=4.4.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
* fix: register impls against govtypes.Content interface

* test: adding codec type registration test to 02-client/types
* docs: fix broken links

* docs: fix more links

* docs: fix broken sdk links

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
* nit: panic with error

* panic with error

* replace sprintf with errorf in panic

* Update upgrade_test.go

* Update upgrade_test.go

* linter

* Update client_state.go

* fix test

* ftm.Errorf -> errors.New

* fix
…n suite.Run() (#4658)

* rebind loop variable in genesis_test.go

* nits

* rebind loop variable and wrap the actual test logic inside a suite.Run

* nits

* linting

* fix variable name in capability test

* Update modules/core/02-client/types/height_test.go

Co-authored-by: Damian Nolan <[email protected]>

* Update modules/core/03-connection/types/version_test.go

Co-authored-by: Damian Nolan <[email protected]>

* nits: fix duplicated suite.Run()

---------

Co-authored-by: Damian Nolan <[email protected]>
@crodriguezvega
Copy link
Contributor Author

Closing for now, but will keep the branch, so that I can pick it up again later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.