Skip to content

fix: properly store errors in Iterator.Next() method #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2025
Merged

fix: properly store errors in Iterator.Next() method #1090

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2476099
fix: properly store errors in Iterator.Next() method
GarmashAlex Apr 29, 2025
4ecc53e
Update iterator.go
GarmashAlex Apr 30, 2025
35203fd
Update iterator.go
GarmashAlex May 1, 2025
6495277
Merge branch 'master' into hpp1
May 14, 2025
2cb564b
Merge branch 'master' into hpp1
May 15, 2025
b720618
add test
GarmashAlex May 15, 2025
4e806cc
Merge branch 'master' into hpp1
May 27, 2025
225c562
Update iterator_test.go
GarmashAlex May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion iterator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,11 @@ func (iter *Iterator) Next() {
}

node, err := iter.t.next()
// TODO: double-check if this error is correctly handled.
// If an error occurred or no more nodes, update iterator state accordingly
if node == nil || err != nil {
if err != nil {
iter.err = err
}
iter.t = nil
iter.valid = false
return
Expand Down