feat: add support for ed25519 tx signature verification
#23283
Merged
+97
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis pull request introduces support for ed25519 transaction signatures in the Cosmos SDK. The changes span multiple files, including Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
zivkovicmilos
requested review from
a team,
JulianToledano and
raynaudoe
as code owners
julienrbrt
reviewed
Jan 9, 2025
x/auth/ante/sigverify.go
Outdated
| @@ -112,18 +110,16 @@ func OnlyLegacyAminoSigners(sigData signing.SignatureData) bool { | |||
| } | |||
|
|
|||
| func (svd SigVerificationDecorator) VerifyIsOnCurve(pubKey cryptotypes.PubKey) error { | |||
| if svd.extraVerifyIsOnCurve != nil { | |||
There was a problem hiding this comment.
Please revert this change. It is always nil if you use NewSigVerificationDecorator but if you use the NewSigVerificationDecoratorWithVerifyOnCurve you can specify one.
This is a feature that just got added (#23128) :D
There was a problem hiding this comment.
Ah, didn't realize it's relatively new 🤦♂️
I just saw that it's always nil, so I dropped it.
Reverted:
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CHANGELOG.md (3)
Line range hint
1-1: Add a title to the CHANGELOG fileThe file should start with a descriptive title like "# Changelog" to clearly identify its purpose.
+ # Changelog
48-48: Fix inconsistent version header formattingThe version header for v0.47.15 is missing the release date in parentheses, unlike other version headers.
- ## [v0.47.15](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.15) + ## [v0.47.15](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.15) - 2024-12-16
Line range hint
785-785: Improve clarity of breaking change descriptionThe description "Bump Go version minimum requirement to 1.19" should include the previous version for better context.
- * (deps) [#13397](https://github.com/cosmos/cosmos-sdk/pull/13397) Bump Go version minimum requirement to `1.19`. + * (deps) [#13397](https://github.com/cosmos/cosmos-sdk/pull/13397) Update minimum required Go version from 1.18 to 1.19.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
CHANGELOG.md(1 hunks)crypto/keys/ed25519/ed25519.go(4 hunks)crypto/keys/ed25519/ed25519_test.go(2 hunks)go.mod(1 hunks)x/auth/ante/sigverify.go(3 hunks)x/auth/ante/sigverify_test.go(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
x/auth/ante/sigverify_test.go (2)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
crypto/keys/ed25519/ed25519_test.go (2)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
crypto/keys/ed25519/ed25519.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
x/auth/ante/sigverify.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: tests (03)
- GitHub Check: tests (02)
- GitHub Check: tests (01)
- GitHub Check: tests (00)
- GitHub Check: test-simapp-v2
- GitHub Check: test-system-v2
- GitHub Check: test-integration
- GitHub Check: build (amd64)
- GitHub Check: Analyze
- GitHub Check: Summary
🔇 Additional comments (9)
crypto/keys/ed25519/ed25519.go (2)
235-238: Well-documented constant for curve validation!The
identityPointvariable is properly documented and correctly represents the neutral element (0,1) in Edwards curve form.
240-264: Robust implementation of curve validation!The
IsOnCurvemethod implements comprehensive validation:
- Validates key size
- Ensures point is on the curve
- Rejects identity point (neutral element)
This implementation aligns with cryptographic best practices for ed25519 key validation.
crypto/keys/ed25519/ed25519_test.go (1)
260-295: Excellent test coverage for curve validation!The test suite comprehensively covers all critical scenarios:
- Invalid public key size
- Identity point rejection
- Valid public key acceptance
Good use of
t.Parallel()for test efficiency.x/auth/ante/sigverify.go (2)
119-122: Clean integration of ed25519 curve validation!The implementation properly integrates the new
IsOnCurvecheck for ed25519 keys, maintaining consistency with other key type validations.
533-533: Proper gas consumption for ed25519 signatures!The implementation now correctly consumes gas for ed25519 signature verification without raising an error, enabling support for ed25519 transaction signatures.
x/auth/ante/sigverify_test.go (1)
77-77: Test expectation correctly updated!The test case for ed25519 signature verification now expects success, aligning with the implementation changes that support ed25519 transaction signatures.
go.mod (2)
19-19: Verify the selected version of edwards25519.The addition of
filippo.io/edwards25519as a direct dependency is appropriate for supporting ed25519 signature verification. However, let's verify if v1.1.0 is the most suitable version.Run this script to check available versions and their release dates:
✅ Verification successful
The selected version v1.1.0 of edwards25519 is appropriate.
The codebase uses only stable, core functionality (point operations, curve validation) that is well-supported in v1.1.0. The integration with CometBFT's crypto packages is clean and shows no compatibility issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check available versions of edwards25519 and their release dates gh api \ -H "Accept: application/vnd.github+json" \ repos/FiloSottile/edwards25519/releases \ --jq '.[] | {tag_name: .tag_name, published_at: .published_at}'Length of output: 153
Script:
#!/bin/bash # Search for edwards25519 imports and usage patterns echo "=== Searching for edwards25519 imports ===" rg -l "filippo\.io/edwards25519" --type go echo -e "\n=== Checking for version-specific code patterns ===" rg "edwards25519" --type go -C 2 echo -e "\n=== Looking for documentation mentioning edwards25519 ===" fd -e md -e txt | xargs rg "edwards25519"Length of output: 2197
19-19: Verify compatibility with existing crypto packages.The addition looks good, but let's ensure there are no conflicts with other cryptographic dependencies in use.
Run this script to check for potential conflicts:
✅ Verification successful
Dependency is properly integrated and compatible
The
filippo.io/edwards25519 v1.1.0package is already well-integrated into the codebase, used specifically for ed25519 curve operations in the crypto/keys/ed25519 package. There are no conflicts with other cryptographic dependencies, and the version is consistent throughout the codebase.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for other crypto-related dependencies that might conflict rg -l "ed25519|curve25519|edwards25519" | grep -v "go.mod" # Check imports in crypto-related files ast-grep --pattern 'import ($$$)' | grep -i "crypto\|ed25519\|curve25519"Length of output: 65912
Script:
#!/bin/bash # Check go.sum for edwards25519 versions echo "=== Checking go.sum for edwards25519 versions ===" grep "filippo.io/edwards25519" go.sum # Look for direct imports of edwards25519 echo -e "\n=== Checking direct imports of edwards25519 ===" rg --type go "filippo.io/edwards25519" -l # Look for actual usage of edwards25519 types/functions echo -e "\n=== Checking usage of edwards25519 package ===" rg --type go "edwards25519\." -B 2 -A 2Length of output: 1753
CHANGELOG.md (1)
Line range hint
1-2500: Overall documentation quality is goodThe CHANGELOG follows proper semantic versioning, includes relevant categorization of changes, and provides good traceability through PR links. The descriptions are generally clear and informative.
tac0turtle
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
x/auth/ante/sigverify.go (1)
541-541: Consider validating the ED25519 gas cost parameter.While the implementation correctly uses the ED25519 gas cost parameter, consider adding validation to ensure the parameter value is reasonable (e.g., not zero or negative) when it's set in the params.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
x/auth/ante/sigverify.go(2 hunks)x/auth/ante/sigverify_test.go(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- x/auth/ante/sigverify_test.go
🧰 Additional context used
📓 Path-based instructions (1)
x/auth/ante/sigverify.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
x/auth/ante/sigverify.go (1)
127-130: LGTM! Well-structured ed25519 curve validation.The implementation follows consistent patterns with other key types and properly handles error cases.
|
Thank you for resolving the conflicts 🙏 Let me know if there are additional changes required for the PR, I noticed the v2 core tests were failing: |
|
@zivkovicmilos because of my merge, there are some lint issues - do you think you can resolve? |
|
Before this gets merged @zivkovicmilos, could you update: https://docs.cosmos.network/main/learn/beginner/accounts#keys-accounts-addresses-and-signatures ( ) |
Ran the linter with the latest upstream changes, no linting errors are showing up: make lint
--> Running linter
/Applications/Xcode.app/Contents/Developer/usr/bin/make lint-install
--> Installing golangci-lint v1.61.0
go: downloading github.com/golangci/golangci-lint v1.61.0
go: downloading golang.org/x/exp v0.0.0-20240904232852-e7e105dedf7e
go: downloading github.com/go-viper/mapstructure/v2 v2.1.0
go: downloading github.com/Abirdcfly/dupword v0.1.1
go: downloading github.com/tetafro/godot v1.4.17
go: downloading github.com/securego/gosec/v2 v2.21.2
go: downloading github.com/ckaznocha/intrange v0.2.0
go: downloading github.com/mgechev/revive v1.3.9
go: downloading github.com/sivchari/tenv v1.10.0
go: downloading github.com/Antonboom/testifylint v1.4.3
linting module github.com/cosmos/cosmos-sdk [2025-01-27T15:36:46+00:00]
linting module cosmossdk.io/tools/benchmark [2025-01-27T15:37:16+00:00]
linting module cosmossdk.io/tools/hubl [2025-01-27T15:37:19+00:00]
linting module cosmossdk.io/tools/cosmovisor [2025-01-27T15:37:30+00:00]
linting module cosmossdk.io/tools/confix [2025-01-27T15:37:42+00:00]
linting module cosmossdk.io/core [2025-01-27T15:37:48+00:00]
linting module cosmossdk.io/core/testing [2025-01-27T15:37:48+00:00]
linting module cosmossdk.io/simapp/v2 [2025-01-27T15:37:51+00:00]
linting module cosmossdk.io/systemtests [2025-01-27T15:38:13+00:00]
linting module cosmossdk.io/runtime/v2 [2025-01-27T15:38:17+00:00]
linting module github.com/cosmos/cosmos-sdk/tests [2025-01-27T15:38:30+00:00]
linting module github.com/cosmos/cosmos-sdk/tests/systemtests [2025-01-27T15:38:47+00:00]
linting module cosmossdk.io/server/v2/appmanager [2025-01-27T15:38:50+00:00]
linting module cosmossdk.io/server/v2 [2025-01-27T15:38:50+00:00]
linting module cosmossdk.io/server/v2/cometbft [2025-01-27T15:38:53+00:00]
linting module cosmossdk.io/server/v2/stf [2025-01-27T15:38:55+00:00]
linting module cosmossdk.io/math [2025-01-27T15:38:56+00:00]
linting module cosmossdk.io/schema [2025-01-27T15:38:58+00:00]
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.12) of your project is lower than Go 1.22
linting module cosmossdk.io/schema/testing [2025-01-27T15:38:59+00:00]
linting module cosmossdk.io/api [2025-01-27T15:39:00+00:00]
linting module cosmossdk.io/log [2025-01-27T15:39:07+00:00]
linting module cosmossdk.io/orm [2025-01-27T15:39:07+00:00]
linting module cosmossdk.io/errors/v2 [2025-01-27T15:39:10+00:00]
linting module cosmossdk.io/collections [2025-01-27T15:39:10+00:00]
linting module cosmossdk.io/collections/protocodec [2025-01-27T15:39:12+00:00]
linting module cosmossdk.io/depinject [2025-01-27T15:39:12+00:00]
linting module cosmossdk.io/client/v2 [2025-01-27T15:39:14+00:00]
linting module cosmossdk.io/indexer/postgres [2025-01-27T15:39:19+00:00]
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.12) of your project is lower than Go 1.22
linting module cosmossdk.io/indexer/postgres/testing [2025-01-27T15:39:20+00:00]
linting module cosmossdk.io/x/consensus [2025-01-27T15:39:21+00:00]
linting module cosmossdk.io/x/upgrade [2025-01-27T15:39:23+00:00]
linting module cosmossdk.io/x/feegrant [2025-01-27T15:39:26+00:00]
linting module cosmossdk.io/x/mint [2025-01-27T15:39:30+00:00]
linting module cosmossdk.io/x/evidence [2025-01-27T15:39:33+00:00]
linting module cosmossdk.io/x/nft [2025-01-27T15:39:35+00:00]
linting module cosmossdk.io/x/group [2025-01-27T15:39:37+00:00]
linting module cosmossdk.io/x/bank [2025-01-27T15:39:40+00:00]
linting module cosmossdk.io/x/circuit [2025-01-27T15:39:43+00:00]
linting module cosmossdk.io/x/distribution [2025-01-27T15:39:45+00:00]
linting module cosmossdk.io/x/tx [2025-01-27T15:39:49+00:00]
linting module cosmossdk.io/x/accounts [2025-01-27T15:39:51+00:00]
linting module cosmossdk.io/x/accounts/defaults/multisig [2025-01-27T15:39:53+00:00]
linting module cosmossdk.io/x/accounts/defaults/lockup [2025-01-27T15:39:55+00:00]
linting module cosmossdk.io/x/accounts/defaults/base [2025-01-27T15:39:56+00:00]
linting module cosmossdk.io/x/epochs [2025-01-27T15:39:58+00:00]
linting module cosmossdk.io/x/protocolpool [2025-01-27T15:39:59+00:00]
linting module cosmossdk.io/x/staking [2025-01-27T15:40:01+00:00]
linting module cosmossdk.io/x/authz [2025-01-27T15:40:06+00:00]
linting module cosmossdk.io/x/slashing [2025-01-27T15:40:09+00:00]
linting module cosmossdk.io/x/gov [2025-01-27T15:40:11+00:00]
linting module cosmossdk.io/store [2025-01-27T15:40:14+00:00]
linting module cosmossdk.io/store/v2 [2025-01-27T15:40:16+00:00]Edit: It was a |
|
Good catch 💯 I've updated it here: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/learn/beginner/03-accounts.md (1)
Line range hint
1-100: Enhance documentation for ed25519 transaction signing.While the table has been updated to reflect ed25519 transaction signing support, consider adding more details in the following sections:
- Under "Keys, accounts, addresses, and signatures" section: Add information about ed25519 transaction signing capabilities and any specific considerations.
- In the "Public Keys" section: Include details about ed25519 public key serialization format.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/learn/beginner/03-accounts.md(1 hunks)go.mod(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
🧰 Additional context used
📓 Path-based instructions (1)
docs/learn/beginner/03-accounts.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
docs/learn/beginner/03-accounts.md (1)
56-59: Verify the updated tm-ed25519 specifications.The changes to the tm-ed25519 entry in the table accurately reflect the new support for transaction authentication. However, let's verify a few technical details:
Additionally, consider adding a note below the table explaining that tm-ed25519 support for transaction authentication is a new feature, to help users understand this significant change.
|
There seems to be some issue with echo "Ensure dependencies have not been modified ..." >&2
Ensure dependencies have not been modified ...
go mod verify
all modules verified
go mod tidy
cd /Users/zmilos/Work/cosmos-sdk/simapp/v2 && \
\
CC=cc \
go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simdv2 -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0 -X github.com/cosmos/cosmos-sdk/version.Commit=18eeff8d53cf113e77faf298124428a5aee901b7 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -w -s' -trimpath -o /Users/zmilos/Work/cosmos-sdk/build/ ./...
mkdir -p ./tests/systemtests/binaries/
cp /Users/zmilos/Work/cosmos-sdk/build/simdv2 ./tests/systemtests/binaries/
COSMOS_BUILD_OPTIONS=v2 /Applications/Xcode.app/Contents/Developer/usr/bin/make -C tests/systemtests test
go test -mod=readonly -failfast -timeout=15m -tags='system_test' ./... --wait-time=45s --verbose --binary=simdv2
Work dir: /Users/zmilos/Work/cosmos-sdk/tests/systemtests
Setup chain: ./testnet
+++ /Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 testnet init-files --chain-id=testing --output-dir=./testnet --validator-count=4 --keyring-backend=test --commit-timeout=900ms --single-host --server.minimum-gas-prices=0.000001stake
Node dir testnet/node0/simdv2
Node dir testnet/node1/simdv2
Node dir testnet/node2/simdv2
Node dir testnet/node3/simdv2
Stop chain
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 comet unsafe-reset-all --home ./testnet/node0/simdv2`
Result: I[2025-01-27|15:56:48.191] Removed all blockchain history dir=testnet/node0/simdv2/data
I[2025-01-27|15:56:48.191] Reset private validator file to genesis state keyFile=testnet/node0/simdv2/config/priv_validator_key.json stateFile=testnet/node0/simdv2/data/priv_validator_state.json
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 comet unsafe-reset-all --home ./testnet/node1/simdv2`
Result: I[2025-01-27|15:56:48.236] Removed all blockchain history dir=testnet/node1/simdv2/data
I[2025-01-27|15:56:48.237] Reset private validator file to genesis state keyFile=testnet/node1/simdv2/config/priv_validator_key.json stateFile=testnet/node1/simdv2/data/priv_validator_state.json
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 comet unsafe-reset-all --home ./testnet/node2/simdv2`
Result: I[2025-01-27|15:56:48.282] Removed all blockchain history dir=testnet/node2/simdv2/data
I[2025-01-27|15:56:48.283] Reset private validator file to genesis state keyFile=testnet/node2/simdv2/config/priv_validator_key.json stateFile=testnet/node2/simdv2/data/priv_validator_state.json
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 comet unsafe-reset-all --home ./testnet/node3/simdv2`
Result: I[2025-01-27|15:56:48.328] Removed all blockchain history dir=testnet/node3/simdv2/data
I[2025-01-27|15:56:48.328] Reset private validator file to genesis state keyFile=testnet/node3/simdv2/config/priv_validator_key.json stateFile=testnet/node3/simdv2/data/priv_validator_state.json
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 genesis add-genesis-account cosmos19cvd5h4qpfm923yv8ye83xu64ght5yz5k3htzf 10000000stake --home ./testnet/node0/simdv2`
Result:
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 genesis add-genesis-account cosmos19cvd5h4qpfm923yv8ye83xu64ght5yz5k3htzf 10000000stake --home ./testnet/node1/simdv2`
Result:
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 genesis add-genesis-account cosmos19cvd5h4qpfm923yv8ye83xu64ght5yz5k3htzf 10000000stake --home ./testnet/node2/simdv2`
Result:
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 genesis add-genesis-account cosmos19cvd5h4qpfm923yv8ye83xu64ght5yz5k3htzf 10000000stake --home ./testnet/node3/simdv2`
Result:
Start chain
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 start --log_level=info --log_no_color --home=./testnet/node0/simdv2`
Node started: 28673
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 start --log_level=info --log_no_color --home=./testnet/node1/simdv2`
Node started: 28674
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 start --log_level=info --log_no_color --home=./testnet/node2/simdv2`
Node started: 28675
Execute `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 start --log_level=info --log_no_color --home=./testnet/node3/simdv2`
Node started: 28676
Node stopped: 28674
Node stopped: 28676
Node stopped: 28675
--- FAIL: TestAccountCreation (45.48s)
account_test.go:23: Reset chain
cli.go:323: +++ running `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 keys add account1 --no-backup --home /Users/zmilos/Work/cosmos-sdk/tests/systemtests/testnet --keyring-backend test --output json`
cli.go:323: +++ output: {"name":"account1","type":"local","address":"cosmos19cvd5h4qpfm923yv8ye83xu64ght5yz5k3htzf","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"A3CkEKUIWp0kfV4OZRVibIvH78xBPvBZoYbdb/R4dzaM\"}"}
cli.go:323: +++ running `/Users/zmilos/Work/cosmos-sdk/tests/systemtests/binaries/simdv2 keys add account2 --no-backup --home /Users/zmilos/Work/cosmos-sdk/tests/systemtests/testnet --keyring-backend test --output json`
cli.go:323: +++ output: {"name":"account2","type":"local","address":"cosmos1z0watna4766gr6vxny9r66g70fpfsgcxaq076r","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"Ak2GPwvCRVP/kzfXll+3ks3DxuhPuT4vm61VIYRvFQL6\"}"}
account_test.go:33: Await node is up: tcp://localhost:26657
system.go:297: Checking node status: tcp://localhost:26657
account_test.go:33: timeout waiting for node start: 45s
FAIL
Stop chain
killing node 28673
Node stopped: 28673
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52458
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52458
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52458
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52458
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52460
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52460
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52460
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52460
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52462
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52462
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52462
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52462
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52464
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52464
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52464
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52464
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52466
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52466
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52466
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52466
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52468
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52468
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52468
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52468
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52470
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52470
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52470
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52470
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52472
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52472
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52472
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52472
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52474
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52474
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52474
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52474
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52476
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52476
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52476
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52476
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52478
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52478
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52478
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52478
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52480
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52480
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52480
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52480
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52482
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52482
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52482
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52482
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52484
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52484
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52484
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52484
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52486
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52486
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52486
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52486
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52488
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52488
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52488
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52488
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52490
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52490
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52490
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52490
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52452
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52452
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52452
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52452
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52454
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52454
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52454
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52454
out> 4:57PM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket
out> 4:57PM INF New websocket connection module=rpc-server protocol=websocket remote=127.0.0.1:52456
out> 4:57PM INF service start impl=wsConnection module=rpc-server msg="Starting wsConnection service" protocol=websocket remote=127.0.0.1:52456
out> 4:57PM INF Client closed the connection module=rpc-server protocol=websocket remote=127.0.0.1:52456
out> 4:57PM INF service stop impl=wsConnection module=rpc-server msg="Stopping wsConnection service" protocol=websocket remote=127.0.0.1:52456
8< chain err -----------------------------------------
err> panic: runtime error: invalid memory address or nil pointer dereference
err> [signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x1031477b0]
err>
err> goroutine 25 [running]:
err> github.com/cosmos/iavl.(*MutableTree).Get(0x140010c5b30?, {0x1400102ac30?, 0x14001f70e98?, 0x1032fd4b0?})
err> github.com/cosmos/iavl@v1.3.4/mutable_tree.go:182 +0x20
err> cosmossdk.io/store/v2/commitment/iavl.(*IavlTree).Get(0x140012e58d0, 0x0, {0x1400102ac30, 0x15, 0x15})
err> cosmossdk.io/store/v2@v2.0.0/commitment/iavl/tree.go:127 +0x110
err> cosmossdk.io/store/v2/commitment.(*CommitStore).Get(0x0?, {0x1400190e1a0, 0x3, 0x8}, 0x0, {0x1400102ac30, 0x15, 0x15})
err> cosmossdk.io/store/v2@v2.0.0/commitment/store.go:370 +0x70
err> cosmossdk.io/store/v2/root.(*Reader).Get(0x0?, {0x1400102ac30?, 0x0?, 0x0?})
err> cosmossdk.io/store/v2@v2.0.0/root/reader.go:57 +0x58
err> cosmossdk.io/server/v2/stf/branch.Store[...].Get(0x105eaf7a0?, {0x1400102ac30?, 0x15?, 0x15})
err> cosmossdk.io/server/v2/stf@v1.0.0-beta.2/branch/store.go:33 +0x70
err> cosmossdk.io/collections.Map[...].Get(0x1, {0x105e874d8, 0x1400181ebd0}, {0x1400102ac18, 0x14, 0x15})
err> cosmossdk.io/collections@v1.0.0/map.go:103 +0xb8
err> cosmossdk.io/collections.(*IndexedMap[...]).Get(...)
err> cosmossdk.io/collections@v1.0.0/indexed_map.go:125
err> cosmossdk.io/collections.(*IndexedMap[...].func1()
err> cosmossdk.io/collections@v1.0.0/indexed_map.go:213 +0x5c
err> cosmossdk.io/collections/indexes.(*Unique[...]).Reference(0x105ee9720, {0x105e874d8, 0x1400181ebd0}, {0x1400102ac18, 0x14, 0x15}, {0x105eab6a0, 0x1400181f4d0}, 0x15)
err> cosmossdk.io/collections@v1.0.0/indexes/unique.go:35 +0x50
err> cosmossdk.io/collections.(*IndexedMap[...]).ref(0x105eee900, {0x105e874d8, 0x1400181ebd0}, {0x1400102ac18, 0x14, 0x15}, {0x105eab6a0, 0x1400181f4d0})
err> cosmossdk.io/collections@v1.0.0/indexed_map.go:179 +0x1b0
err> cosmossdk.io/collections.(*IndexedMap[...]).Set(0x105eee900, {0x105e874d8, 0x1400181ebd0}, {0x1400102ac18, 0x14, 0x15}, {0x105eab6a0, 0x1400181f4d0})
err> cosmossdk.io/collections@v1.0.0/indexed_map.go:141 +0x50
err> github.com/cosmos/cosmos-sdk/x/auth/keeper.AccountKeeper.SetAccount({{{0x14f27ab98, 0x14000d4c5b0}, {0x14f1c1598, 0x10800abe0}, {0x105e42560, 0x14001820870}, {0x105e586c0, 0x10800abe0}, {0x105e42520, 0x14001820860}, ...}, ...}, ...)
err> github.com/cosmos/cosmos-sdk@v0.53.0/x/auth/keeper/account.go:54 +0x64
err> github.com/cosmos/cosmos-sdk/x/auth/keeper.AccountKeeper.InitGenesis({{{0x14f27ab98, 0x14000d4c5b0}, {0x14f1c1598, 0x10800abe0}, {0x105e42560, 0x14001820870}, {0x105e586c0, 0x10800abe0}, {0x105e42520, 0x14001820860}, ...}, ...}, ...)
err> github.com/cosmos/cosmos-sdk@v0.53.0/x/auth/keeper/genesis.go:37 +0x1ec
err> github.com/cosmos/cosmos-sdk/x/auth.AppModule.InitGenesis({{{{0x14f27ab98, 0x14000d4c5b0}, {0x14f1c1598, 0x10800abe0}, {0x105e42560, 0x14001820870}, {0x105e586c0, 0x10800abe0}, {0x105e42520, 0x14001820860}, ...}, ...}, ...}, ...)
err> github.com/cosmos/cosmos-sdk@v0.53.0/x/auth/module.go:149 +0xd8
err> cosmossdk.io/runtime/v2.(*MM[...]).InitGenesisJSON(0x0, {0x105e874d8?, 0x1400181ebd0}, 0x1400181eb40, 0x1400181eb10)
err> cosmossdk.io/runtime/v2@v2.0.0-00010101000000-000000000000/manager.go:185 +0x5f0
err> cosmossdk.io/runtime/v2.(*AppBuilder[...]).initGenesis.func1()
err> cosmossdk.io/runtime/v2@v2.0.0-00010101000000-000000000000/builder.go:165 +0x64
err> cosmossdk.io/runtime/v2/services.genesisContext.Mutate({{0x14f1da268, 0x14002866660}}, {0x105e874d8, 0x1400181eab0}, 0x140018121d8)
err> cosmossdk.io/runtime/v2@v2.0.0-00010101000000-000000000000/services/genesis.go:49 +0xf0
err> cosmossdk.io/runtime/v2.(*AppBuilder[...]).initGenesis(0x105ed1760, {0x105e874d8, 0x1400181eab0}, {0x105e41c28, 0x1400181eae0?}, 0x1400181eb10?)
err> cosmossdk.io/runtime/v2@v2.0.0-00010101000000-000000000000/builder.go:164 +0x290
err> cosmossdk.io/server/v2/appmanager.appManager[...].InitGenesis(0x105eb6ee0, {0x105e874d8, 0x1400181eab0}, 0x140006ef100, {0x14001e40000, 0x4974, 0x4a80}, {0x105e574e0, 0x14002d02240})
err> cosmossdk.io/server/v2/appmanager@v1.0.0-beta.2/appmanager.go:124 +0x10c
err> cosmossdk.io/server/v2/cometbft.(*consensus[...]).InitChain(0x10223f614, {0x105e875f0?, 0x10800abe0}, 0x14003860ee0)
err> cosmossdk.io/server/v2/cometbft@v0.0.0-20241015140036-ee3d320eaa55/abci.go:318 +0x3c8
err> github.com/cometbft/cometbft/abci/client.(*localClient).InitChain(0x14ef78a60?, {0x105e875f0?, 0x10800abe0?}, 0x108195878?)
err> github.com/cometbft/cometbft@v1.0.0/abci/client/local_client.go:125 +0xe4
err> github.com/cometbft/cometbft/proxy.(*appConnConsensus).InitChain(0x14001314fd8, {0x105e875f0, 0x10800abe0}, 0x14003860ee0)
err> github.com/cometbft/cometbft@v1.0.0/proxy/app_conn.go:77 +0x124
err> github.com/cometbft/cometbft/internal/consensus.(*Handshaker).ReplayBlocks(_, {_, _}, {{{0xb, 0x0}, {0x104afe214, 0x5}}, {0x14001880645, 0x7}, 0x1, ...}, ...)
err> github.com/cometbft/cometbft@v1.0.0/internal/consensus/replay.go:324 +0xd78
err> github.com/cometbft/cometbft/internal/consensus.(*Handshaker).Handshake(0x14001f731c8, {0x105e87510, 0x14001139310}, {0x105eb1cd8, 0x14002d041c0})
err> github.com/cometbft/cometbft@v1.0.0/internal/consensus/replay.go:268 +0x360
err> github.com/cometbft/cometbft/node.doHandshake({_, _}, {_, _}, {{{0xb, 0x0}, {0x104afe214, 0x5}}, {0x14001880645, 0x7}, ...}, ...)
err> github.com/cometbft/cometbft@v1.0.0/node/setup.go:239 +0x118
err> github.com/cometbft/cometbft/node.NewNodeWithCliParams({0x105e87510, 0x14001139310}, 0x140013708c0, {0x105e87218, 0x14001714000}, 0x1400201a000, {0x105e87708, 0x1400201a150}, 0x14001813f18, 0x105e2c150, ...)
err> github.com/cometbft/cometbft@v1.0.0/node/node.go:405 +0x87c
err> github.com/cometbft/cometbft/node.NewNode(...)
err> github.com/cometbft/cometbft@v1.0.0/node/node.go:286
err> cosmossdk.io/server/v2/cometbft.(*CometBFTServer[...]).Start(0x0, {0x105e87510?, 0x14001139310})
err> cosmossdk.io/server/v2/cometbft@v0.0.0-20241015140036-ee3d320eaa55/server.go:259 +0x338
err> cosmossdk.io/server/v2.(*Server[...]).Start.func1()
err> cosmossdk.io/server/v2@v2.0.0-beta.1/server.go:100 +0x38
err> created by cosmossdk.io/server/v2.(*Server[...]).Start in goroutine 1
err> cosmossdk.io/server/v2@v2.0.0-beta.1/server.go:99 +0x13c
__ _ _ _
/ _| (_) | | |
| |_ __ _ _| | ___ __| |
| _/ _| | | |/ _ \/ _| |
| || (_| | | | __/ (_| |
|_| \__,_|_|_|\___|\__,_|
FAIL github.com/cosmos/cosmos-sdk/tests/systemtests 47.152s
FAIL
make[1]: *** [test] Error 1
make: *** [test-system] Error 2
Maybe I'm running it on a wrong machine (mac), but I get the same error on |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
47-48: Fix inconsistent formatting in changelog entriesThe entries for x/auth/ante features are not properly aligned with other entries in the Features section. Add proper indentation.
-* (x/auth/ante) [#23128](https://github.com/cosmos/cosmos-sdk/pull/23128) Allow custom verifyIsOnCurve when validate tx for public key like ethsecp256k1. -* (x/auth/ante) [#23283](https://github.com/cosmos/cosmos-sdk/pull/23283) Allow ed25519 transaction signatures. + * (x/auth/ante) [#23128](https://github.com/cosmos/cosmos-sdk/pull/23128) Allow custom verifyIsOnCurve when validate tx for public key like ethsecp256k1. + * (x/auth/ante) [#23283](https://github.com/cosmos/cosmos-sdk/pull/23283) Allow ed25519 transaction signatures.
Line range hint
785-786: Fix grammatical error in changelog entryThe sentence has incorrect grammar in the bug fix description.
-* (x/auth) [#5892](https://github.com/cosmos/cosmos-sdk/pull/5892) Add `RegisterKeyTypeCodec` to register new -types (eg. keys) to the `auth` module internal amino codec. +* (x/auth) [#5892](https://github.com/cosmos/cosmos-sdk/pull/5892) Add `RegisterKeyTypeCodec` to register new +types (e.g., keys) to the `auth` module's internal amino codec.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)go.mod(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
CHANGELOG.md (1)
Line range hint
1-1500: LGTM on overall changelog structure and organizationThe changelog follows proper semantic versioning and Keep a Changelog format with clear sections for Features, Improvements, Bug Fixes, and Breaking Changes. The descriptions are generally clear and provide good context.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CHANGELOG.md (3)
47-48: Add missing period in feature descriptionAdd a period at the end of the sentence for consistency with other entries.
-* (x/auth/ante) [#23128](https://github.com/cosmos/cosmos-sdk/pull/23128) Allow custom verifyIsOnCurve when validate tx for public key like ethsecp256k1 +* (x/auth/ante) [#23128](https://github.com/cosmos/cosmos-sdk/pull/23128) Allow custom verifyIsOnCurve when validate tx for public key like ethsecp256k1.
1311-1314: Fix inconsistent bullet point formattingThe bullet points under "Client Breaking Changes" are inconsistently formatted. Some use
*while others use-. Standardize on one format.-* [#8363](https://github.com/cosmos/cosmos-sdk/pull/8363) Addresses no longer have a fixed 20-byte length. From the SDK modules' point of view, any 1-255 bytes-long byte array is a valid address. -* (crypto/ed25519) [#8690] Adopt zip1215 ed2559 verification rules. -* [#8849](https://github.com/cosmos/cosmos-sdk/pull/8849) Upgrade module no longer supports time based upgrades. -* [#7477](https://github.com/cosmos/cosmos-sdk/pull/7477) Changed Bech32 Public Key serialization in the client facing functionality (CLI, MsgServer, QueryServer): +* [#8363](https://github.com/cosmos/cosmos-sdk/pull/8363) Addresses no longer have a fixed 20-byte length. From the SDK modules' point of view, any 1-255 bytes-long byte array is a valid address. +* (crypto/ed25519) [#8690] Adopt zip1215 ed2559 verification rules. +* [#8849](https://github.com/cosmos/cosmos-sdk/pull/8849) Upgrade module no longer supports time based upgrades. +* [#7477](https://github.com/cosmos/cosmos-sdk/pull/7477) Changed Bech32 Public Key serialization in the client facing functionality (CLI, MsgServer, QueryServer):
1311-1311: Fix missing pull request linkThe pull request link is missing for the ed25519 change.
-* (crypto/ed25519) [#8690] Adopt zip1215 ed2559 verification rules. +* (crypto/ed25519) [#8690](https://github.com/cosmos/cosmos-sdk/pull/8690) Adopt zip1215 ed2559 verification rules.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)x/auth/ante/sigverify.go(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
x/auth/ante/sigverify.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: tests (00)
- GitHub Check: test-simapp-v2
- GitHub Check: test-sim-nondeterminism
- GitHub Check: test-integration
- GitHub Check: build (amd64)
- GitHub Check: test-system-v2
- GitHub Check: Analyze
- GitHub Check: markdown-link-check
- GitHub Check: Summary
🔇 Additional comments (4)
x/auth/ante/sigverify.go (2)
128-131: LGTM: ed25519 curve validation implementation.The implementation correctly validates ed25519 public keys using the
IsOnCurve()method and returns an appropriate error message when validation fails.
548-548: LGTM: ed25519 gas consumption implementation.The implementation correctly consumes gas for ed25519 signature verification using the appropriate parameter from the params struct.
CHANGELOG.md (2)
1-3: LGTM! Clear and informative PR summaryThe PR summary clearly explains the purpose and scope of the changes.
4-12: LGTM! Well-structured comments sectionThe comments section provides good context about the collaborative efforts and issues encountered during development.
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Co-authored-by: Alex | Interchain Labs <alex@skip.money> Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io> Co-authored-by: Marko <marko@baricevic.me> (cherry picked from commit d3e059d) # Conflicts: # CHANGELOG.md # go.mod
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1861 (for real)
This PR introduces support for
ed25519transaction signing.The original issue was brought up in #1861, but still the support remained missing in the SDK.
It also promotes a dependency from indirect to direct (
filippo.io/edwards25519), since it has handy methods for verifyinged25519public keys.There is logic for subtracting gas from the gas meter when an
ed25519signature is encountered, but a simple error is always returned:cosmos-sdk/x/auth/ante/sigverify.go
Lines 537 to 540 in 80b1422
The change is backwards compatible, as it doesn't break existing SDK logic.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Release Notes
New Features
Improvements
Documentation
tm-ed25519scheme for both transaction authentication and consensus.Dependency Updates
filippo.io/edwards25519package.These changes enhance the cryptographic signature handling and provide more robust key validation in the transaction signing process.