WIP: refactor(store/v2,server/v2): save genesis block at height 0 #22406
Conversation
Co-authored-by: Matt Kocubinski <[email protected]>
… kocu/tx-load-test
github-actions
bot
added
C:CLI
C:Store
C:x/genutil
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| go func() { | ||
| resCh <- mod.Start(ctx) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| @@ -111,14 +121,20 @@ func (s *Server[T]) Stop(ctx context.Context) error { | |||
| logger := GetLoggerFromContext(ctx) | |||
| logger.With(log.ModuleKey, s.Name()).Info("stopping servers...") | |||
|
|
|||
| g, ctx := errgroup.WithContext(ctx) | |||
| // cannot reuse context as it's already canceled, so create a new one for stopping | |||
There was a problem hiding this comment.
As this resolves #22405, could you extract in a seperate PR? It is unrelated to the genesis issue
There was a problem hiding this comment.
There's still a problem with it... Stop() can be called before Start() completes. >.<
I think the start command needs another look. I will probably reverse this change in this branch before r4r, but right now it's helpful during development.
There was a problem hiding this comment.
Isn't this super easily fixable by deferring the Stop instead of doing what we do now?
github-actions
bot
added
C:x/staking
C:x/gov
C:x/slashing
C:x/distribution
| @@ -0,0 +1,9 @@ | |||
| package benchmark | |||
There was a problem hiding this comment.
it may make more sense to put this in tools
| treeOpts.StateStorage = true | ||
| treeOpts.EvictionDepth = 20 | ||
| treeOpts.HeightFilter = 0 |
There was a problem hiding this comment.
should these be config values?
|
obviated by #22435 |
Description
Depends on: cosmos/iavl#1002
core
Versionfield tocore/store.Changeset.store/v2
WorkingHash(store.Changeset)from all store/v2 interfaces.store/v2.VersionedWriter.ApplyChangesetis now 1-arity,versionparameter removed (it's now in the Changeset)store/v2/root.Commit(store.Changeset)now passesversionto the commit store from the Changeset instead of fetching from SC on write.SetCommitHeaderfrom root store interface (unused)server/v2
InitChainnow callsCommit(store.Changeset)instead ofWorkingHash(store.Changeset)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...