Skip to content

Updated strip hit threshold logic #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckierans merged 5 commits into from
Feb 6, 2026
+0 −1
Merged

Updated strip hit threshold logic #81

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0445f37
Updated strip hit threshold logic, and now have QA flag to not filter…
ckierans Dec 18, 2025
a1add80
Merge branch 'develop/em' into threshold_fix
ckierans Jan 13, 2026
a8db144
Included better tracking for hits removed through threshold cut, and …
ckierans Jan 20, 2026
3ccb3b1
Merge branch 'develop/em' into threshold_fix
ckierans Jan 20, 2026
2142335
Merge branch 'develop/em' into threshold_fix
ckierans Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions include/MReadOutAssembly.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,7 @@ class MReadOutAssembly : public MReadOutSequence
bool IsEnergyResolutionCalibrationIncomplete() const { return m_EnergyResolutionCalibrationIncomplete; }

//! set the Strip Hit Below Threshold flag
void SetStripHitBelowThreshold(bool Flag = true, MString Text = ""){
m_StripHitBelowThreshold = Flag; m_StripHitBelowThreshold = Text;}
void SetStripHitBelowThreshold(bool Flag = true, MString Text = ""){ m_StripHitBelowThreshold = Flag; m_StripHitBelowThresholdString = Text;}
//! get the Strip Hit Below Threshold flag
bool IsStripHitBelowThreshold() const { return m_StripHitBelowThreshold; }

Expand Down Expand Up @@ -432,7 +431,7 @@ class MReadOutAssembly : public MReadOutSequence
//! Reduced Chi^2 of the Strip Paired Event
double m_ReducedChiSquare;

// Flags indicating the quality of the event
// Flags indicating the quality of the event: incomplete calibration
bool m_AspectIncomplete;
MString m_AspectIncompleteString;
bool m_TimeIncomplete;
Expand All @@ -451,10 +450,12 @@ class MReadOutAssembly : public MReadOutSequence
MString m_DepthCalibrationIncompleteString;
bool m_DepthCalibration_OutofRange;
MString m_DepthCalibration_OutofRangeString;
bool m_StripHitBelowThreshold;
MString m_StripHitBelowThresholdString;


// Flags indicating the quality of the event: quality warning, but not to be filtered out
Copy link
Collaborator

@zoglauer zoglauer Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the names are already long:
...Incomplete always results in a bad flag
... Do you want something similar for the quality flags?

Think of soemthing - or something similar
m_StripHitBelowThresholdQF;
m_StripHitBelowThresholdQualityFlag;

bool m_StripHitBelowThreshold;
MString m_StripHitBelowThresholdString;


//! True if event has been filtered out
bool m_FilteredOut;
Expand Down
Loading