Skip to content

Merge back PR248 onto develop#403

Merged
israelmcmc merged 8 commits intocositools:developfrom
israelmcmc:merge_back_PR248
Sep 15, 2025
Merged

Merge back PR248 onto develop#403
israelmcmc merged 8 commits intocositools:developfrom
israelmcmc:merge_back_PR248

Conversation

@israelmcmc
Copy link
Collaborator

This code by @Yong2Sheng has already been reviewed in #248. I rebased it onto the v0.3.x branch, and merged through #350. I was planning to merge it onto develop right after v0.3 was released, but I forgot.

I'm opening this PR for our records, and to make sure the tests are passing. I'll merge it right after, no need to review it again.

盛勇 and others added 8 commits April 10, 2025 15:14
…mpatiable with the MOC map fitting.

[IMD: Resolved conflicts during rebase.]

Signed-off-by: Israel Martinez <[email protected]>
[IMC: Resolve conflicts]

Signed-off-by: Israel Martinez <[email protected]>
….x_merge_develop

# Conflicts:
#	docs/tutorials/ts_map/TS_map_fitting.ipynb
…k_PR248

# Conflicts:
#	docs/tutorials/ts_map/TS_map_fitting.ipynb
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.78%. Comparing base (22abd1c) to head (b4166f6).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
cosipy/ts_map/moc_ts_fit.py 22.33% 80 Missing ⚠️
cosipy/ts_map/fast_ts_fit.py 88.23% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
cosipy/__init__.py 100.00% <100.00%> (ø)
cosipy/ts_map/__init__.py 100.00% <100.00%> (ø)
cosipy/ts_map/fast_ts_fit.py 89.61% <88.23%> (-0.39%) ⬇️
cosipy/ts_map/moc_ts_fit.py 22.33% <22.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@israelmcmc israelmcmc merged commit 074681a into cositools:develop Sep 15, 2025
3 of 4 checks passed
@israelmcmc israelmcmc changed the title Merge back PR248 into develop Merge back PR248 onto develop Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants