Skip to content

Conversation

@igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Mar 18, 2024

Context

The Freehand ROI annotation SR hydration was not working for both SR and Cornerstone viewports

Changes & Results

  • Freehand ROI SRs are created and hydrated properly in OHIF

Testing

  • Link to OHIF locally and create/load a Freehand ROI SR

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

N/A

Public Documentation Updates

N/A

Tested Environment

  • "OS: 14.4.1 (23E224)
  • "Node version: 16.14
  • "Browser: Chrome Version 123.0.6312.59 (Official Build) (x86_64)

@netlify
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit c2bbfc1
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/660f38316ccd5800079474da

@igoroctaviano igoroctaviano changed the title [WIP] fix(cornerstone-dicom-sr): Freehand SR loading fix(cornerstone-dicom-sr): Freehand SR loading Mar 18, 2024
epsilon: 0.1,
},
calculateStats: false,
calculateStats: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set it back to false, it is brutal to calculate stats on each frame

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats were not being calculated / displayed. Maybe the problem is the tool implementation or when the stats are calculated?

@igoroctaviano igoroctaviano requested a review from sedghi March 27, 2024 20:30
@igoroctaviano igoroctaviano changed the title fix(cornerstone-dicom-sr): Freehand SR loading fix(cornerstone-dicom-sr): Freehand SR hydrating support Mar 28, 2024
@igoroctaviano igoroctaviano changed the title fix(cornerstone-dicom-sr): Freehand SR hydrating support fix(cornerstone-dicom-sr): Freehand SR hydration support Mar 28, 2024
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great thanks

@sedghi sedghi merged commit 5e778a1 into cornerstonejs:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants