Repository navigation
Conversation
sookyboo
marked this pull request as draft
October 6, 2026 17:59
sookyboo
marked this pull request as ready for review
October 6, 2026 18:27
Owner
|
Landed on main by fast-forward (rebased onto main; full |
corepunch
added a commit
that referenced
this pull request
Oct 6, 2026
- Backdrop alpha: opaque is now opt-in (Q2 Draw_Pic never drops alpha). DRAW_BLEND_ALL is replaced by DRAW_BG_OPAQUE, honoured only when the background tint is fully opaque. uiBackdrop_t.BlendAll becomes Opaque (same bit) so zero-initialized WoW layouts (UI_WriteWelcomeWindow) and WoW XML/Lua backdrops blend again; WC3 hud/menu set it from FDF !BackdropBlendAll. R_DrawImageBatchOpaque folds into R_DrawImageBatchEx with params.opaque; redundant BlendAll=true assignments dropped. - JASS dialogs: Clear/Destroy free slots for reuse; ids carry a reuse generation ((gen << 16) | slot+1) so stale ids from registrations, events, saves and late jassdialog clicks are rejected. Exhaustion is logged. jassdialog accepts any uint32 id and lets the game validate. ReadGame rejects out-of-range dialog slot counts. - Load republishes the choice dialog only from ClientBegin (was twice). - Fixture common.j declares dialog/button types (retail does) so JASS globals holding them snapshot; tests cover slot reuse, stale ids, malformed/foreign/duplicate jassdialog, sleep-across-save click context, single restore, and backdrop opacity in renderer/menu/hud. - Nits: snapshot v7 comment, UI capacity printed from the define, merged DialogDisplay branches, EscMenu key table beside wide keys. Network: byte layout unchanged; uiBackdrop_t bit 1 now means Opaque (was BlendAll, ignored by clients before #590). Save: version 66 -> 67 (dialog/button id meaning changed); 66 rejected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Warcraft III JASS choice dialogs with
DialogCreate, button creation, display, and click-event handling. Add modal input and UI support, preserve player identity through click events and save/load, and release temporary dialog frames when dialogs are cleared.Match the stock EscMenu look for dialog backgrounds and button states. Preserve race-specific skin keys through image resolution so Night Elf and Undead button art renders correctly, including disabled and pushed states.
Document the dialog API, event behavior, limits, and remaining compatibility gaps. Add regression coverage for dialog lifecycle, player identity, save/load, button styling, and race-specific image resolution.
Tests:
make test— 46,845 assertions across 2,340 tests. WC3 engine tests pass in classic and TFT modes.Test with: jass Trig_Fork_Dialog_Actions
in -tft +map "Maps\FrozenThrone\Campaign\NightElfX06.w3x"