Repository navigation
Fix campaign arrow and cinematic icon centering - #578
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaign arrow and cinematic camera icons were shifted within their button borders because backdrop rendering ignored the authored FDF background size and sampled only the upper-left portion of each inset texture. Carry that size through glue and retained HUD drawing, then calculate UV repeats from the authored tile span after insets so the full icon stays centered.
Add retail ROC/TFT button backdrop fixtures and regression coverage for both icons in normal, pressed, and disabled states, plus renderer coverage for resolution independence, custom spans, unequal insets, mirroring, repetition, and invalid geometry. Document the source data and verification commands.
The required full rebuild also exposed WC3 AI warnings: retain trace-only values explicitly and fix a conversion macro's self-shadowing rawcode temporary, with coverage of authored, added, and ranked abilities.
Validation:
make testpassed, including ROC/TFT engine suites.make -j4 wc3-build openwow opensc2passed without compiler warnings.git diff --checkpassed.