Repository navigation
Fix missing background music in Linux releases - #574
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published Linux tarball built with
FFMPEG=0, which disables background music as well as movies:CL_MusicOpenTrackbecomes a stub returning false. A localmake build -j4 FFMPEG=1build has the decoder, explaining the music difference without changing SDL or the ordinary sound-effects mixer.Build Linux releases with FFmpeg and bundle their media runtime dependencies with local RUNPATHs and package copyright notices. Keep the host's libc, C++ runtime and graphics interfaces so Ubuntu libraries cannot replace those required by newer Manjaro drivers. Add an optimized Linux build/package CI check and document FFmpeg build dependencies in the README.
Validation:
make test TEST_JOBS=4passed locally and the full Linux CI test job passed. The Linux/GCC media build and package check passed, resolving all five FFmpeg libraries from the packagedlib/directory; optimized sound tests passed all 1,687 assertions. Five packaging regressions cover decoder absence, unresolved libraries, runtime paths and notices. A filesystem regression reads a loose file underTéléchargements/Games WIP/ROC, ruling out the reported UTF-8/spaces root-path hypothesis for that path.Scope: this fixes missing Linux release music. Ordinary unit voices/effects use the existing WAV/minimp3 path; their silence has not been reproduced. The reported black menu background remains a separate, unconfirmed asset/model issue and is not claimed fixed here.