Repository navigation
Announce published releases in Discord - #572
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published releases were never announced because Discord Notify only subscribed to PR events. Add release publication cards using the existing webhook, plus a manual tag input to announce missed published releases such as v0.0.10-alpha. Draft/unpublished releases are rejected, mentions stay disabled, and missing credentials or HTTP delivery failures fail the release job.
Keep the privileged notification workflow free of checkouts. A separate unprivileged CI job runs seven fixtures against the actual Bash/jq scripts, covering formatting, catch-up lookup, eligibility, delivery failures and existing PR cards. Update the notification guide with the new triggers and explicit duplicate-post behavior for manual reruns.
Validation:
python3 tests/test_discord_notifications.pypassed all seven tests; both workflow YAML files parse; documentation links andgit diff --checkpass. No game code or fixtures changed, so no local game build is required.Protocol/save impact: none. Proposed split: keep this small workflow, fixture and documentation change together.