[Copilot]

Overview

This PR migrates the network functionality from low-level POSIX sockets to SDL_net library, improving cross-platform compatibility and integrating better with the project's existing SDL2 architecture.

Changes Made

Network Implementation

• Replaced POSIX socket API with SDL2_net.h (removed sys/socket.h, netinet/in.h, arpa/inet.h, etc.)
• Implemented socket handle mapping to convert between DWORD handles and SDL_net TCPsocket pointers
• Updated TCP functions:
  • NET_Write → uses SDLNet_TCP_Send
  • NET_Read → uses SDLNet_TCP_Recv
  • NET_TCPListen → uses SDLNet_ResolveHost + SDLNet_TCP_Open
  • NET_TCPAccept → uses SDLNet_TCP_Accept
  • NET_TCPConnect → uses SDLNet_ResolveHost + SDLNet_TCP_Open
  • NET_CloseSocket → uses SDLNet_TCP_Close
• Updated UDP discovery (NET_DiscoverGames) to use SDL_net UDP functions
• Removed NET_SetNonBlocking (SDL_net handles non-blocking internally)
• Added initialization: SDLNet_Init/SDLNet_Quit calls in Com_Init/Com_Quit

Build Configuration

• Updated Makefile to link SDL2_net library
• No changes needed to src/common/net.h - API remains compatible

Security & Robustness

• Added buffer overflow protection in UDP packet handling
• Proper byte ordering using SDLNet_ResolveHost for broadcast addresses
• Enhanced error handling for invalid socket handles

Testing

• ✅ Code compiles successfully on Linux with no errors or warnings
• ✅ All network API functions remain compatible with existing code
• ✅ The loopback implementation (USE_LOOPBACK) remains unchanged for local development

Benefits

• Cross-platform compatibility through SDL abstraction
• Consistency with the project's existing SDL2 usage
• Simplified network code without manual socket management or platform-specific conditional compilation
• Better integration with the game's SDL-based architecture

Original prompt

Update network functionality to use SDL instead of lowlevel

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[corepunch]

@copilot retry

[Copilot]

@copilot retry

I've completed the migration from low-level POSIX sockets to SDL_net. The implementation includes:

Changes made:

• Replaced all POSIX socket calls (socket, bind, listen, accept, connect, send, recv) with SDL_net equivalents
• Implemented socket handle mapping to manage SDL_net TCPsocket pointers
• Converted UDP discovery to use SDL_net UDP functions
• Added SDLNet_Init/SDLNet_Quit initialization
• Updated Makefile to link SDL2_net

Build status: ✅ Successfully compiles on Linux with no errors

Commit: 4ddee54