This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
device: Disable netlink support for the device used by go-tcmu #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device: Disable netlink support for the device used by go-tcmu
This patch disables netlink support by adding
nl_reply_supported=-1. This makes go-tcmu program possible to runwith other netlink supported program which also uses
target_core_user.ko on the same host.
If some program enabled netlink support on target_core_user.ko,
go-tcmu stops working as it does not implement netlink device event
handling.
Although go-tcmu could implement netlink support, go-tcmu is a
non-daemon process (so not necessary the device event handling) and
kernel upstream kindly accepted to support the option to disabe
netlink support *1.
*1 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.15-rc1&id=b849b4567549d5a54ab34ffacfd48fca05e8b34e
Fixes #15