Fixes/cleanups for SSH key/systemd unit local file embedding #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small cleanups for #289.
No functional changes.
Record the specific ssh_authorized_keys_local entry that produced a key, rather than blaming the ssh_authorized_keys_local array as a whole. Add a test for multiple local files.
The existing checks wouldn't notice unexpected report entries, since "" is always a suffix of any string. Just hardcode the full report string.
Be consistent with the ordering in translateUnit().
Deduplicate code to validate FilesDir, check for path traversal, and read the file.
There's no benefit to including them in the output sshAuthorizedKeys array, and if we had more than one, the config would fail validation.
This was referenced Mar 14, 2023
Closed
travier
reviewed
Mar 14, 2023
Member
|
Otherwise LGTM. |
travier
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address various small items. Follows up on #289.