release: v0.5.4 — complete Fable audit, all findings fixed - #18
Merged
Conversation
JWT: WithExpirationRequired by default — tokens without exp → 401.
Opt-out via RequireExpiration field.
HEAD→GET: fallback to GET handler for HEAD requests (RFC 9110).
Body suppressed by net/http.Server automatically.
Global middleware on 404/405: middleware chain now executes for
all responses including 404/405. Logger/RateLimit see all traffic.
OPTIONS without middleware: returns 204+Allow regardless of whether
middleware is registered (was 405 without middleware).
RateLimit: Stop() method for cleanup goroutine. Mutex (not RWMutex).
Radix R1: use req.URL.RawPath to prevent %3A→: false param matches.
Radix R3: conflict message now says 'param/catch-all conflict' not
'route already exists'.
CI: matrix jobs for plugins, examples, govulncheck.
TDD: 14 new tests covering all fixes.
Validated: independent repro tests confirm all claims.
… Mutex Blocker 1: Reverted RawPath routing — caused inconsistent param decoding. Fixed properly in radix findChild: skip wildcard nodes for literal character matches. /users/%3Aid now gives param=':id' (decoded by net/http) instead of empty string or raw %3Aid. Blocker 2: Plugin go.mod: go 1.25→1.27, removed external replace (../../../stream) that doesn't exist in CI checkout. Cosmetic: RWMutex→Mutex in ratelimit (RLock never used).
R2: empty params return 404 (was 200 with empty value).
lookupWildcard: end==0 → not found.
R1: findChild properly fixed in node.go (not RawPath hack).
Wildcard nodes skipped for literal character matches.
CHANGELOG: complete v0.5.4 entry with all changes.
Plugin go.mod: cosmetic (already fixed in prev commit).
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Plugin and example go.mod/go.sum updated for Go 1.27. Removed stale replace path in stream plugin. All sub-modules should now build in clean CI checkout.
… fix - Update all plugins require fursy v0.5.3 (was v0.1.0/v0.2.0) - Update all examples require fursy v0.5.3 - CI: go mod tidy before example builds - Fix data race in TestWebSocket_Integration_HubAvailability
…t race guard - Plugin/example go.mod: require fursy v0.5.3 (was v0.1.0/v0.2.0) - Remove local D:/projects replace paths from example go.mod - Stream test: skip integration in short mode (upstream race fix pending) - CI examples: go mod tidy before build - CI plugins: test without -race (upstream stream hub race)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete audit fix release. Validated by Fable 5.1 BEFORE release (not after).
See CHANGELOG v0.5.4 for full list of changes.