fix: RateLimit memory leak regression (v0.5.3 hotfix) - #17
Merged
Conversation
REGRESSION in v0.5.2: insertOrd slice grew unbounded because Cleanup() removed keys from map but not from insertOrd. Replaced with proper LRU using container/list + map[string]*list.Element. - GetLimiter: MoveToBack on access (true LRU, not FIFO) - Cleanup: removes from both map and LRU list - evictLRU: O(1) via list.Front + Remove - No stale entries, no duplicate keys - TDD: 2 regression tests (leak repro, duplicate key eviction)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix
Regression in v0.5.2:
insertOrdslice grew unbounded — Cleanup removed from map but not from tracking slice. 50K unique keys → 50K stale entries while map=0.Fix: Replaced
insertOrd []stringwith proper LRU viacontainer/list+map[string]*list.Element. GetLimiter does MoveToBack (true LRU). Cleanup removes from both structures.TDD: 2 regression tests (memory leak repro, duplicate key eviction).
Found by Fable 5.1 re-validation of v0.5.2.