Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm install when using docker inmutable tags #192

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

davidcaste
Copy link
Contributor

Why is this pull request needed and what does it do?

A bug was introduced in release v1.37.2 that made helm fail when using a docker inmutable tag as v1.12.0@sha256:40384aa1f5ea6bfdc77997d243aec73da05f27aed0c5e9d65bfa98933c519d97. This happened because there are some restrictions documented in kubernetes labels (documentation), e.g. a length of 63 characters, only alphanumeric and _, - and . characters.

This PR attempts to fix the problem described above. Some filters were added to filter out the invalid characters present in a docker inmutable label (@ and :), and the length truncated to 63 characters.

Which issues (if any) are related?

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

@mrueg mrueg merged commit 7114b8c into coredns:master Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants