Fix helm install when using docker inmutable tags #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
A bug was introduced in release
v1.37.2
that made helm fail when using a docker inmutable tag asv1.12.0@sha256:40384aa1f5ea6bfdc77997d243aec73da05f27aed0c5e9d65bfa98933c519d97
. This happened because there are some restrictions documented in kubernetes labels (documentation), e.g. a length of 63 characters, only alphanumeric and_
,-
and.
characters.This PR attempts to fix the problem described above. Some filters were added to filter out the invalid characters present in a docker inmutable label (
@
and:
), and the length truncated to 63 characters.Which issues (if any) are related?
Checklist:
Changes are automatically published when merged to
main
. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.