Merge pull request #190 from davidcaste/fix/deployment_app_version_label

Use image.tag for app.kubernetes.io/version label if defined
coredns · Jan 20, 2025 · b7df8ac · b7df8ac
2 parents 59fa883 + 5e32886
commit b7df8ac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: coredns
-version: 1.37.1
+version: 1.37.2
 appVersion: 1.11.4
 home: https://coredns.io
 icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -19,5 +19,5 @@ maintainers:
 type: application
 annotations:
   artifacthub.io/changes: |
-    - kind: changed
-      description: Fixed typo in readme
+    - kind: fixed
+      description: Use image.tag for app.kubernetes.io/version label if defined
diff --git a/charts/coredns/templates/deployment.yaml b/charts/coredns/templates/deployment.yaml
@@ -6,7 +6,7 @@ metadata:
   name: {{ default (include "coredns.fullname" .) .Values.deployment.name }}
   namespace: {{ .Release.Namespace }}
   labels: {{- include "coredns.labels" . | nindent 4 }}
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
 {{- if .Values.customLabels }}
 {{ toYaml .Values.customLabels | indent 4 }}
 {{- end }}