Skip to content

Jimmygabriel/entry-challenge #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byJim wants to merge 8 commits into
base: master
Choose a base branch
from
+79 −1
Open

Jimmygabriel/entry-challenge #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
877b4ec
challenge core-code.io POST/GET
Jun 23, 2020
be79694
Import - dotenv - prettier
Jun 25, 2020
364914c
gitignore
Jun 25, 2020
74bae21
Delete env
byJim Jun 25, 2020
f014e6f
update data file
Jun 25, 2020
1ed4ae3
delete .idea
Jun 25, 2020
e76f49d
dontenv config.ts - .env
Jun 28, 2020
49f3d59
Delete package-lock.json
byJim Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
/node_modules
/dist
/data

.idea
15 changes: 2 additions & 13 deletions src/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
import * as dotenv from "dotenv";

dotenv.config();
let path;
switch (process.env.NODE_ENV) {
case "production":
path = `${__dirname}/./../.env.production`;
break;
default:
path = `${__dirname}/./../.env.development`;
}
dotenv.config({ path: path });
import { PASSWORD_ENV } from "./utils/config";

export const data = {
contactInfo: {
Expand All @@ -21,7 +10,7 @@ export const data = {
username: "Jimmygabriel",
},
credentials: {
password: `${process.env.PASSWORD_ENV}`,
password: `${PASSWORD_ENV}`,
},
personalInfo: {
questions: [
Expand Down
14 changes: 14 additions & 0 deletions src/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import * as dotenv from "dotenv";

dotenv.config();
let path;
switch (process.env.NODE_ENV) {
case "production":
path = `${__dirname}/../../.env.production`;
break;
default:
path = `${__dirname}/../../.env.development`;
}
dotenv.config({ path: path });

export const PASSWORD_ENV = process.env.PASSWORD_ENV;
Copy link
Copy Markdown

@netpoe netpoe Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta es buena iniciativa, aunque no se recomienda utilizar .env-production y .env-[cualquiera]. Siempre utiliza un solo .env porque en tu sesión sólo hay 1 ambiente.

Copy link
Copy Markdown
Author

@byJim byJim Jun 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netpoe gracias, atendi ya tu comentario.