Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM: do not exec the same task twice #1050

Merged
merged 1 commit into from
Feb 26, 2025
Merged

EM: do not exec the same task twice #1050

merged 1 commit into from
Feb 26, 2025

Conversation

gares
Copy link
Member

@gares gares commented Feb 25, 2025

I guess this broke when we started flattening delegated task.
There are two options:

  • we we flatten we filter upfront the tasks that are already done
  • we make exec aware of the cache

I did the latter, since it is more "bullet proof", although the former is in more line with the code that already filters out done tasks when preparing them.

@gares gares marked this pull request as ready for review February 26, 2025 09:04
@gares
Copy link
Member Author

gares commented Feb 26, 2025

After more thinking, I believe this solution is OK.

@rtetley rtetley merged commit 54562da into main Feb 26, 2025
28 checks passed
@gares gares deleted the fix-crazy-redo branch February 26, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants