Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a retry action to avoid sporadic fails #1039

Merged
merged 2 commits into from
Feb 21, 2025
Merged

ci: add a retry action to avoid sporadic fails #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b50c16
ci: add a retry action to avoid sporadic fails
rtetley Feb 19, 2025
ea93302
fix: correct settings in test files
rtetley Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,21 @@ jobs:
diff search-ui/new_yarn.nix search-ui/yarn.nix
- run: nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd language-server && dune build --profile ${{ matrix.profile }}"
- run: nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd client && yarn run install:all && yarn run build:all && yarn run compile"
- run: xvfb-run nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd client && yarn test"
- name: Test xvfb
uses: Wandalen/wretry.action@v3
with:
attempt_limit: 5
attempt_delay: 5000
command: |
xvfb-run nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd client && yarn test"
if: runner.os == 'Linux'
- run: nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd client && yarn test"
- name: Test
uses: Wandalen/wretry.action@v3
with:
attempt_limit: 5
attempt_delay: 5000
command: |
nix develop .#vscoq-${{ matrix.coq }} -c bash -c "cd client && yarn test"
if: runner.os != 'Linux'
- if: ${{ failure() }}
run: cat /tmp/vscoq_init_log.*
Expand Down
4 changes: 2 additions & 2 deletions client/src/test/suite/extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ suite('Should get diagnostics', function () {

const ext = vscode.extensions.getExtension('maximedenes.vscoq')!;
await ext.activate();
vscode.workspace.getConfiguration().update('vscoq.proof.mode','Continuous');
vscode.workspace.getConfiguration().update('vscoq.proof.mode',1);

const doc = await common.openTextFile('basic.v');

Expand All @@ -35,7 +35,7 @@ suite('Should get diagnostics', function () {

const ext = vscode.extensions.getExtension('maximedenes.vscoq')!;
await ext.activate();
vscode.workspace.getConfiguration().update('vscoq.proof.mode','Continuous');
vscode.workspace.getConfiguration().update('vscoq.proof.mode',1);

const doc1 = await common.openTextFile('basic.v');
const doc2 = await common.openTextFile('warn.v');
Expand Down
2 changes: 1 addition & 1 deletion client/src/test/suite/feedback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ suite('Should get diagnostics in the appropriate tab', function () {
const ext = vscode.extensions.getExtension('maximedenes.vscoq')!;
await ext.activate();

vscode.workspace.getConfiguration().update('vscoq.proof.mode','Continuous');
vscode.workspace.getConfiguration().update('vscoq.proof.mode',1);

const doc1 = await common.openTextFile('basic.v');
const doc2 = await common.openTextFile('warn.v');
Expand Down
2 changes: 1 addition & 1 deletion client/src/test/suite/feedback_delegation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ suite('Should get diagnostics in the appropriate tab', function () {
await ext.activate();

vscode.workspace.getConfiguration().update('vscoq.proof.delegation','Delegate');
vscode.workspace.getConfiguration().update('vscoq.proof.mode','Continuous');
vscode.workspace.getConfiguration().update('vscoq.proof.mode',1);

const doc1 = await common.openTextFile('delegate_proof.v');
const doc2 = await common.openTextFile('warn.v');
Expand Down
2 changes: 1 addition & 1 deletion client/src/test/suite/feedback_skip.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ suite('Should get diagnostics in the appropriate tab', function () {
await ext.activate();

vscode.workspace.getConfiguration().update('vscoq.proof.delegation','Skip');
vscode.workspace.getConfiguration().update('vscoq.proof.mode','Continuous');
vscode.workspace.getConfiguration().update('vscoq.proof.mode',1);

const doc1 = await common.openTextFile('delegate_proof.v');

Expand Down
Loading