Skip to content

[16.0][mig] customer_wallet_(account-portal-pos)#397

Open
legalsylvain wants to merge 149 commits intocoopiteasy:16.0from
grap:16.0-mig-pos_customer_wallet-SLG-2026
Open

[16.0][mig] customer_wallet_(account-portal-pos)#397
legalsylvain wants to merge 149 commits intocoopiteasy:16.0from
grap:16.0-mig-pos_customer_wallet-SLG-2026

Conversation

@legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jan 29, 2026

Description

Fixes

  • remove useless dependency to website module.
  • set customer_wallet_pos autoinstallable, otherwise, wallet amount is wrong if point_of_sale is installed.
  • improve computation performance.

refactoring

  • rename modules. So, the modules are next to each other in the repository. Also the main module doesn't require "account" suffix.
    • account_customer_wallet -> customer_wallet
    • portal_customer_wallet -> customer_wallet_portal
    • pos_customer_wallet -> customer_wallet_pos
  • move transient model in wizard folder
  • renaming js file, to follow odoo convention
  • minimum_wallet_amount is now stored

New features

  • account.payment.register : add a banner on payment form, to mention that it is possible to use Wallet Journal.
  • res.partner : new tree view to see all customer wallet amounts.
  • res.partner : add the wallet amount in the top of partner form view
  • res.partner : have the possibility to see the detail of all the moves that justify the current wallet amount. + same in portal.
  • Add possibility to redistribute wallet amount from a partner to another. (or many other.)

Doc

  • full update of documentation. Adding screenshot.

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

@github-grap-bot
Copy link
Contributor

Hi @carmenbianca,
some modules you are maintaining are being modified, check this out!

@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch 2 times, most recently from 27b3f7d to 92d3593 Compare January 29, 2026 09:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.95726% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.43%. Comparing base (110387a) to head (53b5de3).
⚠️ Report is 469 commits behind head on 16.0.

Files with missing lines Patch % Lines
customer_wallet_portal/controllers/portal.py 41.66% 14 Missing ⚠️
customer_wallet_pos/models/pos_session.py 78.94% 10 Missing and 2 partials ⚠️
...let/wizards/customer_wallet_redistribute_wizard.py 77.14% 4 Missing and 4 partials ⚠️
customer_wallet/models/res_partner.py 91.42% 5 Missing and 1 partial ⚠️
customer_wallet/models/account_payment.py 33.33% 1 Missing and 1 partial ⚠️
...er_wallet/wizards/customer_wallet_detail_wizard.py 91.66% 1 Missing and 1 partial ⚠️
...izards/customer_wallet_redistribute_wizard_line.py 86.66% 1 Missing and 1 partial ⚠️
customer_wallet_pos/tests/common.py 97.61% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             16.0     #397       +/-   ##
===========================================
- Coverage   94.17%   81.43%   -12.75%     
===========================================
  Files          34      205      +171     
  Lines         584     2645     +2061     
  Branches       56      262      +206     
===========================================
+ Hits          550     2154     +1604     
- Misses         27      446      +419     
- Partials        7       45       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch 10 times, most recently from c5985a0 to 78a85f3 Compare February 4, 2026 22:23
@legalsylvain
Copy link
Contributor Author

@legalsylvain legalsylvain marked this pull request as ready for review February 4, 2026 22:28
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch from a6bffd8 to 5299fbb Compare February 10, 2026 16:30
@huguesdk huguesdk changed the title [WIP][16.0][mig] customer_wallet_(account-portal-pos) (do not review) [WIP][16.0][mig] customer_wallet_(account-portal-pos) Mar 6, 2026
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
….config

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…t payment method

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…stead of settings

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
…ines

This does not yet live-update in the POS. The window needs to be
reloaded to see the updated balance.

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
… balance

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch from fe04623 to bea6e62 Compare March 9, 2026 13:51
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch from f41c6dc to 94eba48 Compare March 12, 2026 13:25
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch from 94eba48 to 2986dc3 Compare March 12, 2026 13:36
@legalsylvain
Copy link
Contributor Author

legalsylvain commented Mar 12, 2026

Hi.

but first of all: great work, thanks! i tested it functionally, and it works like a charm.

Thanks !

Thanks for your huge review, @huguesdk !

all remarks applied. (~ 80 !) except :

@legalsylvain legalsylvain requested a review from huguesdk March 12, 2026 14:42
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_customer_wallet-SLG-2026 branch from 4c8dace to d50c69c Compare March 12, 2026 14:46
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the work @legalsylvain! lgtm like that. i will do some tweaks afterwards myself, it will be more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants