[12.0][FIX] company_today: Execute every 15 min, remove doall

[carmenbianca]

Signed-off-by: Carmen Bianca Bakker [email protected]

Description

Odoo task (if applicable)

Checklist before approval

• Tests are present (or not needed).
• Credits/copyright have been changed correctly.
• Change log snippet is present.
• (If a new module) Moving this to OCA has been considered.

[codecov-commenter]

Codecov Report

Merging #265 (ec993b2) into 12.0 (0f05213) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             12.0     #265      +/-   ##
==========================================
+ Coverage   70.00%   70.09%   +0.09%     
==========================================
  Files         124      126       +2     
  Lines        1637     1642       +5     
  Branches      316      317       +1     
==========================================
+ Hits         1146     1151       +5     
  Misses        458      458              
  Partials       33       33              

Impacted Files	Coverage Δ
partner_no_unique_bank/models/res_partner_bank.py	100.00% <0.00%> (ø)
partner_no_unique_bank/models/__init__.py	100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[huguesdk]

i think that once per a few hours is enough (for our use case at least). for other use cases, once per hour is ok, i think. there is the (rather unlikely, but still possible) case where odoo is not running at the cron time, but in that case, today will only be off during one hour maximum. i think that this is a reasonable limitation (to put in the readme), compared to computing things over and over uselessly: even if the date does not change, all dependent computed values will be recomputed (since odoo does not check whether the value has changed or not), unless .cron_update_today() first checks whether the value needs to be updated.

[carmenbianca]

for other use cases, once per hour is ok, i think

I am inclined to think not. Nepal has an offset of UTC+5:45.

unless .cron_update_today() first checks whether the value needs to be updated.

I knew I forgot something. I'll do that.

[robinkeunen]

for other use cases, once per hour is ok, i think

I am inclined to think not. Nepal has an offset of UTC+5:45.

Also the town of Eucla (UTC+08:45) at the border of West Australia (UTC+08:00) and Southern Australia (UTC+09:45). Apparently, it was more convenient to relay telegraph messages. Maintained for retro-compatibility I guess...

[robinkeunen]

@carmenbianca should we merge or close ?