Fix: Add storage TTL bump calls #7 - #26
Open
JHON12091986 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add storage TTL bump calls #7
Problem
The TreasuryContract and VotingContract use
env.storage().persistent()to store data, but no TTL bump calls exist. This means contribution history and vote records can be silently deleted by the network.Solution
extend_ttlcalls after every persistent storage write.bump_instance()utility to all contracts that extends instance storage TTL.bump_instance()at the start of every state-changing function.Files Modified
src/treasury.rs: Added TTL bump for persistent storage.src/voting.rs: Added TTL bump for persistent storage.src/lib.rs: Addedbump_instance()utility.Testing
extend_ttlis called after every persistent storage write.Closes #7