Conversation
vsoch
force-pushed
the
add-corona-calico
branch
2 times, most recently
from
cb78c27 to
0ec0c90
Compare
Signed-off-by: vsoch <[email protected]>
The user can install calico (even using the same flannel port) via a CRD for it, adding the rules for it, customizing the Daemonset env and the addresses that the containers use. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
add-corona-calico
branch
from
0ec0c90 to
073e26f
Compare
There was a problem hiding this comment.
This file is too lengthy and almost completely unreviewable.
Should this be taken from the upstream?
There was a problem hiding this comment.
I thought you might say that!
We made some changes for our setup. I could find a way to get from the upstream. I remember you had a command to do edits in place for yaml - could you show me how to do that?
There was a problem hiding this comment.
OK - will be testing a patch strategy this morning.
There was a problem hiding this comment.
Not able to test - something is going on with the container access on our cluster - I am not able to pull anything for the setup.
There was a problem hiding this comment.
OK - was able to get the containers working, and I've been working on this since. I was able to work through the vxlan setup and separate the CRD install to be from upstream, and then our customizations of the daemonset, configmap, and deployment to be separate:
It's a bit cleaner but still too much to review. I tried to do the entire thing with yq but ran into a lot of issues - I think what is happening is that we need the initial creation to happen and for state to change on the node via the daemonset, and then we have to apply our customized daemonset plus removing the ip autodetect. The logical next step is to compare each of the configmap, daemonset, and deployment carefully and try to figure out if it can be more fully automated with yq.
@AkihiroSuda I will get back to this but I need a break - been working on this all day.
There was a problem hiding this comment.
Update: got it down to just the upstream apply, and then changes with yq. There are quite a few, primarily vxlan in the configmap and then environment additions / changes for Felix for the daemonset to support rootless.
2 participants
This is a cleaned up variant to install calico to corona.
This needs a full testing, and looks like some manual work for the rebase.