This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Implement Bot Configuration #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 2, 2019 14:01
System Configuration is a solution that stores configuration data in the xml files (.config) with the same name as the assembly. In our case that would be Miunie.ConsoleApp.dll.config
DraxCodes
reviewed
Jan 2, 2019
Implement suggestion by @DraxCodes. Co-Authored-By: petrspelos <[email protected]>
Charly6596
previously approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Seems great!
I'll just leave a suggestion, how about creating a .md file, with documentation and concerns about usage, design decissions, instead of leaving coments? (refering to the Note @petrspelos added in the tests) To read that note, you'd have to open the test specifically, would be more accesible being in a .md file in my honest opinion.
|
I agree with @Charly6596. I'll create READMEs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#2
Expected feedback
Simplifications, stuff that I forgot, mistakes that I've made, point them out. 🙂
Any other improvements are welcomed.