Implement simple link generator for controllers #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a simple LinkGenerator class that generates URLs from endpoint definitions. Supports two lookup methods: - By controller class and method: Controller::method - By endpoint ID: endpoint.id Path parameters are substituted from provided params array, remaining params are added as query string.
- Register LinkGenerator as api.core.linkGenerator service - Add DI integration tests with real endpoints - Add UsersController fixture for testing path parameters - Add link-generator.md documentation - Update README.md with link to documentation
- Replace deprecated isSingle() with isSimple() in EntityAdapter - Remove deprecated phpstan.neon checkGenericClassInNonGenericObjectType option - Add proper type hints to fix ~40 PHPStan errors: - Helpers.php: Add is_array check for tag priority - ApiRequest.php: Add type assertions for getAttribute - ApiResponse.php: Add instanceof checks for getEntity/getEndpoint - ValidationException.php: Fix sprintf with mixed values - RequestParameterMapping.php: Add type assertion for requestParameters - DecoratedDispatcher.php: Use instanceof for endpoint check - Plugin.php: Add type assertion for config processing - DateTimeTypeMapper.php: Add is_string check for value - Regex.php: Add proper return type hints - Endpoint.php: Use is_string check for pattern attribute - ArrayHydrator.php: Add detailed phpstan-param shape - ArraySerializator.php: Add type assertion for mask - BasicEntity.php: Fix return types and add type assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a simple LinkGenerator class that generates URLs from endpoint definitions. Supports two lookup methods:
Path parameters are substituted from provided params array, remaining params are added as query string.